Skip to content

fix: use Dash branding with Blockchair#722

Merged
HashEngineering merged 1 commit into
masterfrom
fix/blockchair-branding
Aug 26, 2025
Merged

fix: use Dash branding with Blockchair#722
HashEngineering merged 1 commit into
masterfrom
fix/blockchair-branding

Conversation

@HashEngineering
Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering commented Aug 14, 2025

Issue being fixed or feature implemented

What was done?

Change the link for blockchain to include Dash branding

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features

    • None.
  • Bug Fixes

    • None.
  • Chores

    • Updated the Blockchair transaction explorer link in transaction details to include a source parameter. When opening a transaction in Blockchair from the app, the URL now carries attribution (from=dash), improving consistency and context on the explorer side. Other explorers and behaviors remain unchanged.

@HashEngineering HashEngineering self-assigned this Aug 14, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 14, 2025

Walkthrough

Updated the BlockChair transaction URL in TxDetailModel.getExplorerURL to append the query parameter ?from=dash. No other logic or signatures changed.

Changes

Cohort / File(s) Change Summary
Explorer URL parameter update
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift
Adjusted BlockChair transaction URL format to include ?from=dash after the txid; other branches unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through links with whiskers brash,
A trailing query for every dash,
“from=dash” stitched upon the trail,
So explorers know our bunny tale.
With paws on keys and ears held high,
I tweak the URL—and leap on by! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/blockchair-branding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift (1)

93-93: Prefer URLComponents for query parameters for robustness

Minor: constructing URLs via string concatenation is brittle if additional query params are added later. Using URLComponents ensures proper encoding and avoids double-? issues.

Apply this diff:

-            return URL(string: "https://blockchair.com/dash/transaction/\(transactionId)?from=dash")
+            var comps = URLComponents(string: "https://blockchair.com/dash/transaction/\(transactionId)")
+            comps?.queryItems = [URLQueryItem(name: "from", value: "dash")]
+            return comps?.url
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a408d2 and dbd458b.

📒 Files selected for processing (1)
  • DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift (1 hunks)
🔇 Additional comments (1)
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift (1)

93-93: LGTM: Adds Dash branding to Blockchair explorer link

The change correctly appends the from=dash query parameter to the Blockchair transaction URL. No behavioral regressions expected.

Copy link
Copy Markdown
Contributor

@bfoss765 bfoss765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashEngineering HashEngineering merged commit b376ae5 into master Aug 26, 2025
6 checks passed
@HashEngineering HashEngineering deleted the fix/blockchair-branding branch April 20, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants