fix: use Dash branding with Blockchair#722
Conversation
WalkthroughUpdated the BlockChair transaction URL in TxDetailModel.getExplorerURL to append the query parameter ?from=dash. No other logic or signatures changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift (1)
93-93: Prefer URLComponents for query parameters for robustnessMinor: constructing URLs via string concatenation is brittle if additional query params are added later. Using URLComponents ensures proper encoding and avoids double-? issues.
Apply this diff:
- return URL(string: "https://blockchair.com/dash/transaction/\(transactionId)?from=dash") + var comps = URLComponents(string: "https://blockchair.com/dash/transaction/\(transactionId)") + comps?.queryItems = [URLQueryItem(name: "from", value: "dash")] + return comps?.url
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (1)
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift(1 hunks)
🔇 Additional comments (1)
DashWallet/Sources/UI/Tx/Details/Model/TxDetailModel.swift (1)
93-93: LGTM: Adds Dash branding to Blockchair explorer linkThe change correctly appends the
from=dashquery parameter to the Blockchair transaction URL. No behavioral regressions expected.
Issue being fixed or feature implemented
What was done?
Change the link for blockchain to include Dash branding
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
Bug Fixes
Chores