feat: validate destination address for Maya swaps (MO-32)

DashWallet.xcodeproj/project.pbxproj

@@ -1649,6 +1649,9 @@
 		AA0001062AA9F58E00A1B202 /* MayaPortalViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0001042AA9F58E00A1B202 /* MayaPortalViewController.swift */; };
 		AA0002022BA0F58E00A1B301 /* MayaCryptoCurrency.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0002012BA0F58E00A1B301 /* MayaCryptoCurrency.swift */; };
 		AA0002032BA0F58E00A1B301 /* MayaCryptoCurrency.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0002012BA0F58E00A1B301 /* MayaCryptoCurrency.swift */; };
+		AA0003012CA0F58E00A1B401 /* MayaAddressValidator.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0003002CA0F58E00A1B401 /* MayaAddressValidator.swift */; };
+		AA0003022CA0F58E00A1B401 /* MayaAddressValidator.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0003002CA0F58E00A1B401 /* MayaAddressValidator.swift */; };
+		AA0003042CA0F58E00A1B402 /* MayaAddressValidatorTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0003032CA0F58E00A1B402 /* MayaAddressValidatorTests.swift */; };
 		AA0002052BA0F58E00A1B302 /* MayaPool.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0002042BA0F58E00A1B302 /* MayaPool.swift */; };
 		AA0002062BA0F58E00A1B302 /* MayaPool.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0002042BA0F58E00A1B302 /* MayaPool.swift */; };
 		AA0002082BA0F58E00A1B303 /* MayaEndpoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0002072BA0F58E00A1B303 /* MayaEndpoint.swift */; };
@@ -1675,6 +1678,10 @@
 		AA00030F2CA0F58E00B1B405 /* QRCaptureView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA00030D2CA0F58E00B1B405 /* QRCaptureView.swift */; };
 		AA0003112CA0F58E00B1B406 /* GenericQRScannerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0003102CA0F58E00B1B406 /* GenericQRScannerView.swift */; };
 		AA0003122CA0F58E00B1B406 /* GenericQRScannerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0003102CA0F58E00B1B406 /* GenericQRScannerView.swift */; };
+		AA0004012DA0F58E00C1C501 /* AddressSourceView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0004002DA0F58E00C1C501 /* AddressSourceView.swift */; };
+		AA0004022DA0F58E00C1C501 /* AddressSourceView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0004002DA0F58E00C1C501 /* AddressSourceView.swift */; };
+		AA0004042DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0004032DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift */; };
+		AA0004052DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA0004032DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -3225,6 +3232,8 @@
 		AA0001012AA9F58E00A1B201 /* MayaPortalView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaPortalView.swift; sourceTree = "<group>"; };
 		AA0001042AA9F58E00A1B202 /* MayaPortalViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaPortalViewController.swift; sourceTree = "<group>"; };
 		AA0002012BA0F58E00A1B301 /* MayaCryptoCurrency.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaCryptoCurrency.swift; sourceTree = "<group>"; };
+		AA0003002CA0F58E00A1B401 /* MayaAddressValidator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaAddressValidator.swift; sourceTree = "<group>"; };
+		AA0003032CA0F58E00A1B402 /* MayaAddressValidatorTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaAddressValidatorTests.swift; sourceTree = "<group>"; };
 		AA0002042BA0F58E00A1B302 /* MayaPool.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaPool.swift; sourceTree = "<group>"; };
 		AA0002072BA0F58E00A1B303 /* MayaEndpoint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaEndpoint.swift; sourceTree = "<group>"; };
 		AA00020A2BA0F58E00A1B304 /* MayaAPIService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaAPIService.swift; sourceTree = "<group>"; };
@@ -3238,6 +3247,8 @@
 		AA00030A2CA0F58E00B1B404 /* GenericQRScannerController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GenericQRScannerController.swift; sourceTree = "<group>"; };
 		AA00030D2CA0F58E00B1B405 /* QRCaptureView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = QRCaptureView.swift; sourceTree = "<group>"; };
 		AA0003102CA0F58E00B1B406 /* GenericQRScannerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GenericQRScannerView.swift; sourceTree = "<group>"; };
+		AA0004002DA0F58E00C1C501 /* AddressSourceView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AddressSourceView.swift; sourceTree = "<group>"; };
+		AA0004032DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MayaExchangeAddressProvider.swift; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -4108,17 +4119,20 @@
 				AA00030A2CA0F58E00B1B404 /* GenericQRScannerController.swift */,
 				AA00030D2CA0F58E00B1B405 /* QRCaptureView.swift */,
 				AA0003102CA0F58E00B1B406 /* GenericQRScannerView.swift */,
+				AA0004002DA0F58E00C1C501 /* AddressSourceView.swift */,
 			);
 			path = Maya;
 			sourceTree = "<group>";
 		};
 		AA0002192BA0F58E00A1B309 /* Maya */ = {
 			isa = PBXGroup;
 			children = (
+				AA0003002CA0F58E00A1B401 /* MayaAddressValidator.swift */,
 				AA0002012BA0F58E00A1B301 /* MayaCryptoCurrency.swift */,
 				AA0002042BA0F58E00A1B302 /* MayaPool.swift */,
 				AA0002072BA0F58E00A1B303 /* MayaEndpoint.swift */,
 				AA00020A2BA0F58E00A1B304 /* MayaAPIService.swift */,
+				AA0004032DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift */,
 			);
 			path = Maya;
 			sourceTree = "<group>";
@@ -6486,6 +6500,7 @@
 				2A2120EB22145CAE009906DC /* DWAmountInputValidatorTests.m */,
 				471DD1BB290AE30B00E030C8 /* String+DashWalletTests.swift */,
 				47976E492987772700612988 /* AmountObjectTests.swift */,
+				AA0003032CA0F58E00A1B402 /* MayaAddressValidatorTests.swift */,
 			);
 			path = DashWalletTests;
 			sourceTree = "<group>";
@@ -9262,6 +9277,7 @@
 				2A8C24B423336FEA00000D43 /* DWQuickReceiveViewController.m in Sources */,
 				AA0001022AA9F58E00A1B201 /* MayaPortalView.swift in Sources */,
 				AA0001052AA9F58E00A1B202 /* MayaPortalViewController.swift in Sources */,
+				AA0003012CA0F58E00A1B401 /* MayaAddressValidator.swift in Sources */,
 				AA0002022BA0F58E00A1B301 /* MayaCryptoCurrency.swift in Sources */,
 				AA0002052BA0F58E00A1B302 /* MayaPool.swift in Sources */,
 				AA0002082BA0F58E00A1B303 /* MayaEndpoint.swift in Sources */,
@@ -9276,6 +9292,8 @@
 				AA00030B2CA0F58E00B1B404 /* GenericQRScannerController.swift in Sources */,
 				AA00030E2CA0F58E00B1B405 /* QRCaptureView.swift in Sources */,
 				AA0003112CA0F58E00B1B406 /* GenericQRScannerView.swift in Sources */,
+				AA0004012DA0F58E00C1C501 /* AddressSourceView.swift in Sources */,
+				AA0004042DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -9287,6 +9305,7 @@
 				2A2120EC22145CAE009906DC /* DWAmountInputValidatorTests.m in Sources */,
 				471DD1C0290AECE900E030C8 /* String+DashWalletTests.swift in Sources */,
 				47976E4A2987772700612988 /* AmountObjectTests.swift in Sources */,
+				AA0003042CA0F58E00A1B402 /* MayaAddressValidatorTests.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -10165,6 +10184,7 @@
 				1DD7BE9CD62998F12672140D /* RadioButtonRow.swift in Sources */,
 				AA0001032AA9F58E00A1B201 /* MayaPortalView.swift in Sources */,
 				AA0001062AA9F58E00A1B202 /* MayaPortalViewController.swift in Sources */,
+				AA0003022CA0F58E00A1B401 /* MayaAddressValidator.swift in Sources */,
 				AA0002032BA0F58E00A1B301 /* MayaCryptoCurrency.swift in Sources */,
 				AA0002062BA0F58E00A1B302 /* MayaPool.swift in Sources */,
 				AA0002092BA0F58E00A1B303 /* MayaEndpoint.swift in Sources */,
@@ -10179,6 +10199,8 @@
 				AA00030C2CA0F58E00B1B404 /* GenericQRScannerController.swift in Sources */,
 				AA00030F2CA0F58E00B1B405 /* QRCaptureView.swift in Sources */,
 				AA0003122CA0F58E00B1B406 /* GenericQRScannerView.swift in Sources */,
+				AA0004022DA0F58E00C1C501 /* AddressSourceView.swift in Sources */,
+				AA0004052DA0F58E00C1C502 /* MayaExchangeAddressProvider.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

DashWallet/Resources/AppAssets.xcassets/Maya/maya.coinbase.logo.imageset/Contents.json

@@ -0,0 +1,16 @@
+{
+  "images" : [
+    {
+      "filename" : "coinbase-logo.svg",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "preserves-vector-representation" : true,
+    "template-rendering-intent" : "original"
+  }
+}

DashWallet/Resources/AppAssets.xcassets/Maya/maya.uphold.logo.imageset/Contents.json

@@ -0,0 +1,16 @@
+{
+  "images" : [
+    {
+      "filename" : "uphold-logo.svg",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "preserves-vector-representation" : true,
+    "template-rendering-intent" : "original"
+  }
+}

DashWallet/Sources/Models/Coinbase/Accounts/AccountRepository.swift

@@ -85,4 +85,27 @@ class AccountRepository {
 
         return items
     }
+
+    /// Fetch all crypto accounts regardless of balance.
+    /// Used by Maya to find accounts for currencies with zero balance.
+    func allIncludingEmpty() async throws -> [CBAccount] {
+        var items: [CBAccount] = []
+        items.reserveCapacity(300)
+
+        var endpoint: CoinbaseEndpoint? = .accounts
+        while endpoint != nil {
+            let response: BasePaginationResponse<CoinbaseUserAccountData> = try await CoinbaseAPI.shared.request(endpoint!)
+            items += response.data
+                .filter { $0.currency.type == .crypto }
+                .map { .init(info: $0, authInterop: authInterop) }
+
+            if let nextUri = response.pagination.nextURI, !nextUri.isEmpty {
+                endpoint = .path(nextUri)
+            } else {
+                endpoint = nil
+            }
+        }
+
+        return items
+    }
 }

DashWallet/Sources/Models/Coinbase/Accounts/AccountService.swift

@@ -46,6 +46,12 @@ class AccountService {
         try await accountRepository.all()
     }
 
+    /// Returns all crypto accounts regardless of balance.
+    /// Used by Maya to find accounts for currencies with zero balance.
+    public func allAccountsIncludingEmpty() async throws -> [CBAccount] {
+        try await accountRepository.allIncludingEmpty()
+    }
+
     public func retrieveAddress(for accountName: String) async throws -> String {
         let account = try await account(by: accountName)
         return try await account.retrieveAddress()

DashWallet/Sources/Models/Coinbase/Auth/CBAuth.swift

@@ -138,24 +138,17 @@ extension CBAuth {
 extension CBAuth {
     nonisolated
     private var oAuth2URL: URL {
-        let path = CoinbaseEndpoint.signIn.path
-
         var queryItems = [
-            URLQueryItem(name: "redirect_uri", value: Coinbase.redirectUri),
             URLQueryItem(name: "response_type", value: Coinbase.responseType),
+            URLQueryItem(name: "client_id", value: Coinbase.clientID),
+            URLQueryItem(name: "redirect_uri", value: Coinbase.redirectUri),
             URLQueryItem(name: "scope", value: Coinbase.scope),
-            URLQueryItem(name: "meta[send_limit_amount]", value: "\((Coinbase.sendLimitAmount as NSDecimalNumber).intValue)"),
-            URLQueryItem(name: "meta[send_limit_currency]", value: Coinbase.sendLimitCurrency),
-            URLQueryItem(name: "meta[send_limit_period]", value: Coinbase.sendLimitPeriod),
-            URLQueryItem(name: "account", value: Coinbase.account),
         ]
 
-        queryItems.append(URLQueryItem(name: "client_id", value: Coinbase.clientID))
-
         var urlComponents = URLComponents()
         urlComponents.scheme = "https"
-        urlComponents.host = "coinbase.com"
-        urlComponents.path = path
+        urlComponents.host = "login.coinbase.com"
+        urlComponents.path = "/oauth2/auth"
         urlComponents.queryItems = queryItems
 
         guard let url = urlComponents.url else {

DashWallet/Sources/Models/Coinbase/Coinbase+Constants.swift

@@ -19,8 +19,8 @@ import Foundation
 
 extension Coinbase {
     // MARK: API
-    static let callbackURLScheme = "authhub"
-    static let redirectUri = "authhub://oauth-callback"
+    static let callbackURLScheme = "dashwallet"
+    static let redirectUri = "dashwallet://brokers/coinbase/connect"
     static let grantType = "authorization_code"
     static let responseType = "code"
     static let scope =

DashWallet/Sources/Models/Coinbase/Coinbase.swift

@@ -261,6 +261,19 @@ extension Coinbase {
         try await accountService.allAccounts()
     }
 
+    /// Returns all crypto accounts regardless of balance.
+    /// Used by Maya to find accounts for currencies with zero balance.
+    public func accountsIncludingEmpty() async throws -> [CBAccount] {
+        try await accountService.allAccountsIncludingEmpty()
+    }
+
+    /// Fetches a specific account by currency code (e.g., "BTC", "ETH").
+    /// Uses direct `GET /v2/accounts/{currencyCode}` lookup which is more reliable
+    /// than listing all accounts when you know the currency you need.
+    public func account(byCurrencyCode currencyCode: String) async throws -> CBAccount {
+        try await accountService.account(by: currencyCode)
+    }
+
     public func addUserDidChangeListener(_ listener: @escaping UserDidChangeListenerBlock) -> UserDidChangeListenerHandle {
         auth.addUserDidChangeListener(listener)
     }

DashWallet/Sources/Models/Coinbase/Infrastructure/API/CoinbaseAPIEndpoint.swift

@@ -164,13 +164,15 @@ extension CoinbaseEndpoint: TargetType, AccessTokenAuthorizable {
     }
 
     public var baseURL: URL {
-        guard case .path(let string) = self else {
+        switch self {
+        case .getToken, .refreshToken, .revokeToken:
+            return URL(string: "https://login.coinbase.com")!
+        case .path(let string):
+            let path = string.removingPercentEncoding ?? string
+            return URL(string: "https://api.coinbase.com" + path)!
+        default:
             return kBaseURL
         }
-
-        let path = string.removingPercentEncoding ?? string
-        let url = URL(string: "https://api.coinbase.com" + path)!
-        return url
     }
 
     public var path: String {
@@ -188,9 +190,9 @@ extension CoinbaseEndpoint: TargetType, AccessTokenAuthorizable {
         case .swapTradeCommit(let tradeId): return "/v2/trades/\(tradeId)/commit"
         case .accountAddress(let accountId): return "/v2/accounts/\(accountId)/addresses"
         case .createCoinbaseAccountAddress(let accountId): return "/v2/accounts/\(accountId)/addresses"
-        case .getToken, .refreshToken: return "/oauth/token"
-        case .revokeToken: return "/oauth/revoke"
-        case .signIn: return "/oauth/authorize"
+        case .getToken, .refreshToken: return "/oauth2/token"
+        case .revokeToken: return "/oauth2/revoke"
+        case .signIn: return "/oauth2/auth"
         default:
             return ""
         }
@@ -212,13 +214,12 @@ extension CoinbaseEndpoint: TargetType, AccessTokenAuthorizable {
                 "redirect_uri": Coinbase.redirectUri,
                 "code": code,
                 "grant_type": Coinbase.grantType,
-                "account": Coinbase.account,
             ]
 
             queryItems["client_id"] = Coinbase.clientID
             queryItems["client_secret"] = Coinbase.clientSecret
-            
-            return .requestParameters(parameters: queryItems, encoding: JSONEncoding.default)
+
+            return .requestParameters(parameters: queryItems, encoding: URLEncoding.httpBody)
         case .refreshToken(let refreshToken):
             var queryItems: [String: Any] = [
                 "refresh_token": refreshToken,
@@ -227,10 +228,10 @@ extension CoinbaseEndpoint: TargetType, AccessTokenAuthorizable {
 
             queryItems["client_id"] = Coinbase.clientID
             queryItems["client_secret"] = Coinbase.clientSecret
-            
-            return .requestParameters(parameters: queryItems, encoding: JSONEncoding.default)
+
+            return .requestParameters(parameters: queryItems, encoding: URLEncoding.httpBody)
         case .revokeToken(let token):
-            return .requestParameters(parameters: ["token": token], encoding: JSONEncoding.default)
+            return .requestParameters(parameters: ["token": token], encoding: URLEncoding.httpBody)
         case .sendCoinsToWallet(_, _, let dto):
             return .requestJSONEncodable(dto)
         case .swapTrade(let dto):

DashWallet/Sources/Models/Coinbase/Infrastructure/API/DTOs/Account/CoinbaseUserAccountData.swift

@@ -49,8 +49,11 @@ struct CoinbaseUserAccountData: Codable, Identifiable {
     }
 
     var balanceFormatted: String {
+        guard let decimal = balance.amount.decimal() else {
+            return balance.amount
+        }
         let nf = NumberFormatter.cryptoFormatter(currencyCode: currencyCode, exponent: currency.exponent)
-        return nf.string(from: balance.amount.decimal()! as NSNumber)!
+        return nf.string(from: decimal as NSNumber) ?? balance.amount
     }
 
     var fiatBalanceFormatted: String {