feat(ui): redesign About Dash screen#780
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReplaces the legacy About screen with a SwiftUI ChangesAbout Dash SwiftUI Screen
DashUIKit and SwiftUI Utility Cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift`:
- Around line 33-98: The AboutDashView content is not scrollable, causing the
lower sections including menu items and footer text to be clipped on small
screens or with larger text sizes. Wrap the main content VStack (the one with
alignment .leading and spacing 20 that contains appVersion, dashSyncVersion,
exploreStatus, and other menu items) in a ScrollView to enable scrolling on
compact devices. Keep the NavigationBar outside the ScrollView at the top so it
remains visible, and remove or adjust the Spacer() after the ScrollView since it
will no longer be needed for layout purposes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: aa0fabdb-0128-445d-9a14-b0c103a55bcc
⛔ Files ignored due to path filters (9)
DashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/logo.imageset/logo.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/logo.imageset/logo@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/logo.imageset/logo@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/support.imageset/support.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/support.imageset/support@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/support.imageset/support@3x.pngis excluded by!**/*.png
📒 Files selected for processing (7)
DashWallet.xcodeproj/project.pbxprojDashWallet/Resources/AppAssets.xcassets/app-review.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/logo.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/support.imageset/Contents.jsonDashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swiftDashWallet/Sources/UI/Menu/Settings/About/AboutDashViewModel.swiftDashWallet/Sources/UI/Menu/Settings/SettingsScreen.swift
HashEngineering
left a comment
HashEngineering
left a comment
There was a problem hiding this comment.
Is DWAboutViewController a class and set of files that is still needed?
Update Maya and menu UI components for improved About Dash presentation: - Enhance MayaAmountView formatting and layout - Improve LocalCurrencyView display and interaction - Update bridging header configuration - Update project configuration This improves the overall user experience in the About Dash section.
- Update project.pbxproj build settings and references - Add SwiftPM Package.resolved for dependency tracking - Ensure consistent development environment configuration
4 participants
Issue being fixed or feature implemented
This PR redesigns the About Dash screen in Settings to provide a cleaner and more polished presentation of Dash-related information and links.
It improves the existing experience by replacing the older layout with a more structured SwiftUI-based screen, refreshed visuals, and clearer navigation entry points.
What was done?
How Has This Been Tested?
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit