Skip to content

Commit 35a1d45

Browse files
thephezclaude
andcommitted
chore: pin Node to 22.22 via .nvmrc and engines
Add a repo-root .nvmrc and an engines.node range (>=22.22.0 <22.23.0) to the root and every example-app package.json, then point all CI workflows at node-version-file: .nvmrc instead of a hardcoded version so local and CI toolchains stay in lockstep. Each workflow also logs node/npm versions for diagnostics. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 74582a0 commit 35a1d45

13 files changed

Lines changed: 245 additions & 87 deletions

File tree

.github/workflows/dashnote-e2e.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,12 @@ jobs:
4545
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
4646
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
4747
with:
48-
node-version: 24
48+
node-version-file: .nvmrc
49+
50+
- name: Show Node/npm versions
51+
run: |
52+
node -v
53+
npm -v
4954
5055
- name: Install dashnote dependencies
5156
run: npm ci
@@ -107,7 +112,12 @@ jobs:
107112
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
108113
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
109114
with:
110-
node-version: 24
115+
node-version-file: .nvmrc
116+
117+
- name: Show Node/npm versions
118+
run: |
119+
node -v
120+
npm -v
111121
112122
- name: Install dashnote dependencies
113123
run: npm ci

.github/workflows/test-tutorials.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@ jobs:
3535
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
3636
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
3737
with:
38-
node-version: '20'
38+
node-version-file: .nvmrc
39+
- name: Show Node/npm versions
40+
run: |
41+
node -v
42+
npm -v
3943
- run: npm ci
4044
- name: Run read-only tutorial tests
4145
env:
@@ -56,7 +60,11 @@ jobs:
5660
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
5761
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
5862
with:
59-
node-version: '20'
63+
node-version-file: .nvmrc
64+
- name: Show Node/npm versions
65+
run: |
66+
node -v
67+
npm -v
6068
- run: npm ci
6169
- name: Run read-write tutorial tests
6270
env:

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
22.22

example-apps/dashmint-lab/package-lock.json

Lines changed: 58 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example-apps/dashmint-lab/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
"private": true,
66
"version": "0.0.0",
77
"type": "module",
8+
"engines": {
9+
"node": ">=22.22.0 <22.23.0"
10+
},
811
"scripts": {
912
"dev": "vite",
1013
"build": "tsc -b && vite build",

0 commit comments

Comments
 (0)