Skip to content

Commit 25c3347

Browse files
committed
docs(dash): correct fully_verified_count doc on verify_rotated_quorums == false path
The comment claimed `fully_verified_count` is always `0` when `verify_rotated_quorums == false`, but the else branch at the `feed_qr_info` storage step counts every entry of `qualified_last_commitment_per_index` whose `.verified` is `Verified`. Cache hits returned by `known_qualified_quorum_entry` retain their prior `Verified` status (the gate only stores fully-Verified cycles), so the count can be non-zero even with verification disabled. Update the doc to describe the actual behavior. Addresses CodeRabbit review comment on PR #736 #736 (comment)
1 parent 2b17447 commit 25c3347

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

  • dash/src/sml/masternode_list_engine

dash/src/sml/masternode_list_engine/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,11 @@ pub struct QRInfoFeedResult {
8080
/// distinguish cache-hit observability from a trust signal.
8181
pub newly_qualified_count: usize,
8282
/// Rotated quorums whose `.verified` is `LLMQEntryVerificationStatus::Verified`
83-
/// after this call settled. Always `0` when `verify_rotated_quorums == false`.
84-
/// A cycle is only stored in `rotated_quorums_per_cycle` when every entry is
85-
/// `Verified`.
83+
/// after this call settled. May be non-zero even when
84+
/// `verify_rotated_quorums == false` because cached entries returned by
85+
/// `known_qualified_quorum_entry` retain their prior `Verified` status.
86+
/// A cycle is only stored in `rotated_quorums_per_cycle` when every entry
87+
/// is `Verified`.
8688
pub fully_verified_count: usize,
8789
/// Height of the cycle from `last_commitment_per_index` if (and only if)
8890
/// the storage gate fired and the cycle was inserted into

0 commit comments

Comments
 (0)