fix(key-wallet): satisfy CI rustfmt + drop rustdoc link to private item

- Drop the `[`Self::record_transaction`]` link from the
  `ManagedCoreFundsAccount` doc comment; `record_transaction` is
  `pub(crate)` and rustdoc with `-D warnings` rejects intra-doc links
  from a public item to a private one.
- `cargo fmt --all` to fix import ordering (placement of the new
  `ManagedAccountTrait` use lines) and a long-line wrap in
  `account_checker.rs`.

Tests + clippy still clean locally.

Author: QuantumExplorer

dash-spv/tests/dashd_sync/helpers.rs

@@ -63,8 +63,12 @@ pub(super) async fn count_wallet_transactions(
 ) -> usize {
     let wallet_read = wallet.read().await;
     let wallet_info = wallet_read.get_wallet_info(wallet_id).expect("Wallet info not found");
-    let txids: HashSet<_> =
-        wallet_info.accounts().all_accounts().iter().flat_map(|a| a.transactions().keys()).collect();
+    let txids: HashSet<_> = wallet_info
+        .accounts()
+        .all_accounts()
+        .iter()
+        .flat_map(|a| a.transactions().keys())
+        .collect();
     txids.len()
 }
 

key-wallet-ffi/src/address_pool.rs

@@ -12,10 +12,10 @@ use crate::types::{FFIAccountKind, FFIWallet};
 use crate::utils::rust_string_to_c;
 use crate::{check_ptr, deref_ptr, deref_ptr_mut, unwrap_or_return};
 use key_wallet::account::ManagedAccountCollection;
-use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::address_pool::{
     AddressInfo, AddressPool, KeySource, PublicKeyType,
 };
+use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::ManagedCoreFundsAccount;
 use key_wallet::AccountType;
 

key-wallet-ffi/src/managed_account.rs

@@ -20,8 +20,8 @@ use crate::types::{
 use crate::wallet_manager::FFIWalletManager;
 use key_wallet::account::account_collection::{DashpayAccountKey, PlatformPaymentAccountKey};
 use key_wallet::account::TransactionRecord;
-use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::address_pool::AddressPool;
+use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::managed_platform_account::ManagedPlatformAccount;
 use key_wallet::managed_account::ManagedCoreFundsAccount;
 use key_wallet::AccountType;

key-wallet-ffi/src/managed_wallet.rs

@@ -11,8 +11,8 @@ use std::ptr;
 use crate::error::{FFIError, FFIErrorCode};
 use crate::types::FFIWallet;
 use crate::{check_ptr, deref_ptr, deref_ptr_mut, unwrap_or_return};
-use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::address_pool::KeySource;
+use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::wallet::managed_wallet_info::wallet_info_interface::WalletInfoInterface;
 use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
 use std::ffi::c_void;

key-wallet-ffi/src/transaction.rs

@@ -5,7 +5,6 @@ use std::os::raw::c_char;
 use std::ptr;
 use std::slice;
 
-use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use crate::error::{FFIError, FFIErrorCode};
 use crate::types::{
     transaction_context_from_ffi, FFIBlockInfo, FFITransactionContextType, FFIWallet,
@@ -17,6 +16,7 @@ use dashcore::{
     consensus, hashes::Hash, sighash::SighashCache, EcdsaSighashType, Network, OutPoint, Script,
     ScriptBuf, Transaction, TxIn, TxOut, Txid,
 };
+use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::wallet::managed_wallet_info::asset_lock_builder::{
     AssetLockFundingType, CreditOutputFunding,
 };

key-wallet/src/managed_account/managed_account_trait.rs

@@ -14,10 +14,10 @@ use crate::managed_account::address_pool;
 #[cfg(any(feature = "bls", feature = "eddsa"))]
 use crate::managed_account::address_pool::PublicKeyType;
 use crate::managed_account::managed_account_type::ManagedAccountType;
-use crate::Network;
 #[cfg(feature = "eddsa")]
 use crate::AddressInfo;
 use crate::ExtendedPubKey;
+use crate::Network;
 use dashcore::{Address, ScriptBuf, Txid};
 
 /// Common trait for "core" managed account types — both funds-bearing

key-wallet/src/managed_account/managed_core_funds_account.rs

@@ -42,10 +42,10 @@ use std::collections::{BTreeSet, HashSet};
 ///
 /// Most read/write surface comes from [`ManagedAccountTrait`] default methods
 /// — which delegate to the inner keys account via the primitive accessors —
-/// so this struct only carries the funds-specific inherent methods
-/// ([`Self::record_transaction`], the Standard-account receive/change paths,
-/// etc.). The funds-specific state (`balance`, `utxos`) is reachable as a
-/// public field directly.
+/// so this struct only carries the funds-specific inherent methods (transaction
+/// recording, the Standard-account receive/change paths, etc.). The
+/// funds-specific state (`balance`, `utxos`) is reachable as a public field
+/// directly.
 #[derive(Debug, Clone)]
 #[cfg_attr(feature = "serde", derive(Serialize))]
 pub struct ManagedCoreFundsAccount {

key-wallet/src/transaction_checking/account_checker.rs

@@ -595,7 +595,8 @@ impl ManagedCoreFundsAccount {
                 if let Some(payout_info) = self.check_provider_payout(payout_script) {
                     provider_payout_involved = true;
                     // Classify the payout address
-                    if let Ok(payout_address) = Address::from_script(payout_script, self.network()) {
+                    if let Ok(payout_address) = Address::from_script(payout_script, self.network())
+                    {
                         match self.classify_address(&payout_address) {
                             AddressClassification::External => {
                                 involved_receive_addresses.push(payout_info);

key-wallet/src/transaction_checking/transaction_router/tests/routing.rs

@@ -2,8 +2,8 @@
 
 use super::helpers::{test_addr, test_block_info};
 use crate::account::{AccountType, StandardAccountType};
-use crate::managed_account::managed_account_trait::ManagedAccountTrait;
 use crate::managed_account::address_pool::KeySource;
+use crate::managed_account::managed_account_trait::ManagedAccountTrait;
 use crate::managed_account::managed_account_type::ManagedAccountType;
 use crate::test_utils::TestWalletContext;
 use crate::transaction_checking::transaction_router::{

key-wallet/src/wallet/managed_wallet_info/managed_accounts.rs

@@ -8,9 +8,9 @@ use crate::account::BLSAccount;
 #[cfg(feature = "eddsa")]
 use crate::account::EdDSAAccount;
 use crate::account::{Account, AccountType, ManagedCoreFundsAccount};
-use crate::managed_account::managed_account_trait::ManagedAccountTrait;
 use crate::bip32::ExtendedPubKey;
 use crate::error::{Error, Result};
+use crate::managed_account::managed_account_trait::ManagedAccountTrait;
 use crate::wallet::{Wallet, WalletType};
 
 impl ManagedAccountOperations for ManagedWalletInfo {