refactor(key-wallet): drop unused is_watch_only from ManagedCoreAccount

The mutable managed-account state carries an `is_watch_only` field that
is just propagated from the immutable parent `Account` and never read
for any decision in the workspace. Every "is watch-only? then deny"
check (`key-wallet-ffi/src/keys.rs`, `account_derivation.rs`) reads it
off the immutable `Account`, not the managed copy. The denormalized
field has no Rust callers — only test assertions and a `#[no_mangle]`
getter that nothing in this repo invokes.

Drop the field, the `is_watch_only` parameter on `ManagedCoreAccount::new`
and the `create_managed_account_from_*` helpers, the trait method on
`ManagedAccountTrait`, and the FFI export
`managed_core_account_get_is_watch_only`.

Note: `ManagedPlatformAccount.is_watch_only` and the corresponding
`managed_platform_account_get_is_watch_only` FFI export are unchanged.

Breaking change for any out-of-tree consumer of the
`managed_core_account_get_is_watch_only` C ABI; check the parent
`Account.is_watch_only` (exposed via `account_get_is_watch_only`) or the
wallet-level `wallet_is_watch_only` instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: QuantumExplorer

key-wallet-ffi/src/managed_account.rs

@@ -584,23 +584,6 @@ pub unsafe extern "C" fn managed_core_account_get_account_type(
     }
 }
 
-/// Check if a managed account is watch-only
-///
-/// # Safety
-///
-/// - `account` must be a valid pointer to an FFIManagedCoreAccount instance
-#[no_mangle]
-pub unsafe extern "C" fn managed_core_account_get_is_watch_only(
-    account: *const FFIManagedCoreAccount,
-) -> bool {
-    if account.is_null() {
-        return false;
-    }
-
-    let account = &*account;
-    account.inner().is_watch_only
-}
-
 /// Get the balance of a managed account
 ///
 /// # Safety
@@ -1628,10 +1611,7 @@ mod tests {
             assert_eq!(result.error_code, 0);
             assert!(result.error_message.is_null());
 
-            // Verify the account was created successfully
-            let account = &*result.account;
             // Account should exist and be valid
-            assert!(!account.inner().is_watch_only);
 
             // Clean up
             managed_core_account_free(result.account);
@@ -1829,10 +1809,6 @@ mod tests {
             assert_eq!(account_type, FFIAccountKind::StandardBIP44);
             assert_eq!(index_out, 0);
 
-            // Test get_is_watch_only
-            let is_watch_only = managed_core_account_get_is_watch_only(account);
-            assert!(!is_watch_only);
-
             // Test get_balance
             let mut balance_out = crate::types::FFIBalance {
                 confirmed: 999,
@@ -1880,9 +1856,6 @@ mod tests {
             let account_type = managed_core_account_get_account_type(ptr::null(), &mut index_out);
             assert_eq!(account_type, FFIAccountKind::StandardBIP44); // Default type
 
-            let is_watch_only = managed_core_account_get_is_watch_only(ptr::null());
-            assert!(!is_watch_only);
-
             let tx_count = managed_core_account_get_transaction_count(ptr::null());
             assert_eq!(tx_count, 0);
 

key-wallet-ffi/src/managed_wallet.rs

@@ -616,7 +616,6 @@ mod tests {
                 internal_addresses: internal_pool,
             },
             network,
-            false,
         );
 
         managed_collection.standard_bip44_accounts.insert(0, managed_account.clone());

key-wallet-ffi/src/utxo_tests.rs

@@ -205,7 +205,6 @@ mod utxo_tests {
                         .unwrap(),
             },
             Network::Testnet,
-            false,
         );
 
         // Add multiple UTXOs
@@ -308,7 +307,6 @@ mod utxo_tests {
                         .unwrap(),
             },
             Network::Testnet,
-            false,
         );
 
         let utxos = Utxo::dummy_batch(0..2, 10000, 100, false, false);
@@ -334,7 +332,6 @@ mod utxo_tests {
                         .unwrap(),
             },
             Network::Testnet,
-            false,
         );
 
         let utxos = Utxo::dummy_batch(10..11, 20000, 200, false, false);
@@ -353,7 +350,6 @@ mod utxo_tests {
                     .unwrap(),
             },
             Network::Testnet,
-            false,
         );
 
         let utxos = Utxo::dummy_batch(20..22, 30000, 300, false, false);
@@ -412,7 +408,6 @@ mod utxo_tests {
                         .unwrap(),
             },
             Network::Testnet,
-            false,
         );
 
         let utxos = Utxo::dummy_batch(1..2, 10000, 100, false, false);

key-wallet/src/managed_account/managed_account_collection.rs

@@ -513,7 +513,6 @@ impl ManagedAccountCollection {
         Self::create_managed_account_from_account_type(
             account.account_type,
             account.network,
-            account.is_watch_only,
             &key_source,
         )
     }
@@ -527,7 +526,6 @@ impl ManagedAccountCollection {
         Self::create_managed_account_from_account_type(
             account.account_type,
             account.network,
-            account.is_watch_only,
             &key_source,
         )
     }
@@ -546,16 +544,14 @@ impl ManagedAccountCollection {
         Self::create_managed_account_from_account_type(
             account.account_type,
             account.network,
-            account.is_watch_only,
             &key_source,
         )
     }
 
-    /// Create a ManagedAccount from an Account type with network and watch-only status
+    /// Create a ManagedAccount from an Account type with network
     fn create_managed_account_from_account_type(
         account_type: AccountType,
         network: Network,
-        is_watch_only: bool,
         key_source: &KeySource,
     ) -> Result<ManagedCoreAccount, crate::error::Error> {
         // Get the derivation path for this account type
@@ -785,7 +781,7 @@ impl ManagedAccountCollection {
             }
         };
 
-        Ok(ManagedCoreAccount::new(managed_type, network, is_watch_only))
+        Ok(ManagedCoreAccount::new(managed_type, network))
     }
 
     /// Create a ManagedPlatformAccount from an Account for Platform Payment accounts

key-wallet/src/managed_account/managed_account_trait.rs

@@ -30,9 +30,6 @@ pub trait ManagedAccountTrait {
     /// Get mutable metadata
     fn metadata_mut(&mut self) -> &mut AccountMetadata;
 
-    /// Check if this is a watch-only account
-    fn is_watch_only(&self) -> bool;
-
     /// Get balance
     fn balance(&self) -> &WalletCoreBalance;
 

key-wallet/src/managed_account/mod.rs

@@ -56,8 +56,6 @@ pub struct ManagedCoreAccount {
     pub network: Network,
     /// Account metadata
     pub metadata: AccountMetadata,
-    /// Whether this is a watch-only account
-    pub is_watch_only: bool,
     /// Account balance information
     pub balance: WalletCoreBalance,
     /// Transaction history for this account
@@ -76,16 +74,11 @@ pub struct ManagedCoreAccount {
 
 impl ManagedCoreAccount {
     /// Create a new managed account
-    pub fn new(
-        managed_account_type: ManagedAccountType,
-        network: Network,
-        is_watch_only: bool,
-    ) -> Self {
+    pub fn new(managed_account_type: ManagedAccountType, network: Network) -> Self {
         Self {
             managed_account_type,
             network,
             metadata: AccountMetadata::default(),
-            is_watch_only,
             balance: WalletCoreBalance::default(),
             transactions: BTreeMap::new(),
             utxos: BTreeMap::new(),
@@ -129,7 +122,7 @@ impl ManagedCoreAccount {
             .expect("Should succeed with NoKeySource")
         });
 
-        Self::new(managed_type, account.network, account.is_watch_only)
+        Self::new(managed_type, account.network)
     }
 
     /// Create a ManagedAccount from a BLS Account
@@ -153,7 +146,7 @@ impl ManagedCoreAccount {
             .expect("Should succeed with NoKeySource")
         });
 
-        Self::new(managed_type, account.network, account.is_watch_only)
+        Self::new(managed_type, account.network)
     }
 
     /// Create a ManagedAccount from an EdDSA Account
@@ -168,7 +161,7 @@ impl ManagedCoreAccount {
         )
         .expect("Should succeed with NoKeySource");
 
-        Self::new(managed_type, account.network, account.is_watch_only)
+        Self::new(managed_type, account.network)
     }
 
     /// Get the account index
@@ -1310,10 +1303,6 @@ impl ManagedAccountTrait for ManagedCoreAccount {
         &mut self.metadata
     }
 
-    fn is_watch_only(&self) -> bool {
-        self.is_watch_only
-    }
-
     fn balance(&self) -> &WalletCoreBalance {
         &self.balance
     }
@@ -1350,7 +1339,6 @@ impl<'de> Deserialize<'de> for ManagedCoreAccount {
             managed_account_type: ManagedAccountType,
             network: Network,
             metadata: AccountMetadata,
-            is_watch_only: bool,
             balance: WalletCoreBalance,
             transactions: BTreeMap<Txid, TransactionRecord>,
             utxos: BTreeMap<OutPoint, Utxo>,
@@ -1369,7 +1357,6 @@ impl<'de> Deserialize<'de> for ManagedCoreAccount {
             managed_account_type: helper.managed_account_type,
             network: helper.network,
             metadata: helper.metadata,
-            is_watch_only: helper.is_watch_only,
             balance: helper.balance,
             transactions: helper.transactions,
             utxos: helper.utxos,

key-wallet/src/test_utils/account.rs

@@ -34,6 +34,6 @@ impl ManagedCoreAccount {
             internal_addresses: internal_pool,
         };
 
-        ManagedCoreAccount::new(account_type, Network::Regtest, false)
+        ManagedCoreAccount::new(account_type, Network::Regtest)
     }
 }