fix: seed sync checkpoints from birth_height in ManagedWalletInfo ctors (#692)

* fix(key-wallet): seed sync checkpoints from `birth_height` in `ManagedWalletInfo` ctors

`WalletInfoInterface::from_wallet` and `from_wallet_with_name` (plus the inherent `ManagedWalletInfo` constructors) now take `birth_height: CoreBlockHeight` and seed both checkpoint heights (`synced_height`, `last_processed_height`) to `birth_height.saturating_sub(1)` so the next block to scan is always `birth_height`.

Without this, every wallet-add path had to remember `set_birth_height` after construction, and even when called it only set `birth_height`, leaving the checkpoints at `0`. With the per-wallet sync introduced in #694, that dragged `WalletManager::synced_height` (a min across wallets) back to genesis on every add, forcing a re-scan from `0`. Moving the seed into construction makes the invariant a property of the type.

`ManagedWalletInfo::with_birth_height` is removed. It set only `birth_height` and had no callers.

* docs(key-wallet-manager): clarify fallback `birth_height` source on wallet import

Addresses CodeRabbit review comment on PR #692
#692 (comment)

* refactor(key-wallet): drop `WalletInfoInterface::set_birth_height`

The setter only updated `birth_height`, leaving `synced_height` and `last_processed_height` at their previous values, so a caller using it after construction would silently bypass the seeding invariant established by `from_wallet`. With the per-wallet height tracking in #694 that aggregate to a min/max across wallets, this could drag the manager's `synced_height` back to genesis. After the constructor change, the setter has zero callers in-tree, so removing it is the cleanest way to enforce the invariant: `birth_height` is fixed at construction via `from_wallet`.

Addresses CodeRabbit review comment on PR #692
#692 (comment)

* test(key-wallet): pin off-by-one seed contract in `test_wallet_with_managed_info`

Use a non-zero `birth_height` and assert that `metadata.synced_height` and `metadata.last_processed_height` land at `birth_height - 1`, locking the seeding invariant in place.

Addresses CodeRabbit review comment on PR #692
#692 (review)

Author: xdustinface

key-wallet-ffi/src/managed_wallet.rs

@@ -501,7 +501,7 @@ mod tests {
 
         // Create managed wallet info from the wallet heap-allocated like C would do
         let wallet_rust = unsafe { &(*wallet).wallet };
-        let managed_info = ManagedWalletInfo::from_wallet(wallet_rust);
+        let managed_info = ManagedWalletInfo::from_wallet(wallet_rust, 0);
         let ffi_managed = Box::into_raw(Box::new(FFIManagedWalletInfo::new(managed_info)));
 
         // Test get_next_receive_address with valid pointers
@@ -581,7 +581,7 @@ mod tests {
 
         // We need to work with the existing wallet structure
         // Create managed wallet info from the existing wallet
-        let mut managed_info = ManagedWalletInfo::from_wallet(wallet_arc);
+        let mut managed_info = ManagedWalletInfo::from_wallet(wallet_arc, 0);
 
         let network = key_wallet::Network::Testnet;
 
@@ -759,7 +759,7 @@ mod tests {
 
         // Create managed wallet info
         let wallet_arc = unsafe { &(*wallet_ptr).wallet };
-        let mut managed_info = ManagedWalletInfo::from_wallet(wallet_arc);
+        let mut managed_info = ManagedWalletInfo::from_wallet(wallet_arc, 0);
 
         // Set some test balance values
         managed_info.balance = WalletCoreBalance::new(1000000, 50000, 10000, 25000);

key-wallet-ffi/src/transaction.rs

@@ -306,7 +306,7 @@ pub unsafe extern "C" fn wallet_check_transaction(
         use key_wallet::transaction_checking::WalletTransactionChecker;
         use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
 
-        let mut managed_info = ManagedWalletInfo::from_wallet(wallet.inner());
+        let mut managed_info = ManagedWalletInfo::from_wallet(wallet.inner(), 0);
 
         // Check the transaction - wallet is always required now
         let wallet_mut = unwrap_or_return!(wallet.inner_mut(), error);

key-wallet-ffi/src/transaction_checking.rs

@@ -79,7 +79,7 @@ pub unsafe extern "C" fn wallet_create_managed_wallet(
     error: *mut FFIError,
 ) -> *mut FFIManagedWalletInfo {
     let wallet = deref_ptr!(wallet, error);
-    let managed_info = ManagedWalletInfo::from_wallet(wallet.inner());
+    let managed_info = ManagedWalletInfo::from_wallet(wallet.inner(), 0);
     Box::into_raw(Box::new(FFIManagedWalletInfo::new(managed_info)))
 }
 

key-wallet-manager/src/accessors.rs

@@ -249,7 +249,7 @@ mod tests {
     fn insert_wallet_rejects_duplicate() {
         let mut manager: WalletManager<ManagedWalletInfo> = WalletManager::new(Network::Testnet);
         let wallet = build_wallet();
-        let info = ManagedWalletInfo::from_wallet(&wallet);
+        let info = ManagedWalletInfo::from_wallet(&wallet, 0);
 
         let id =
             manager.insert_wallet(wallet.clone(), info.clone()).expect("first insert succeeds");

key-wallet-manager/src/lib.rs

@@ -170,8 +170,7 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
 
         // Create managed wallet info from the wallet to properly initialize accounts
         // This ensures the ManagedAccountCollection is synchronized with the Wallet's accounts
-        let mut managed_info = T::from_wallet(&wallet);
-        managed_info.set_birth_height(birth_height);
+        let mut managed_info = T::from_wallet(&wallet, birth_height);
         managed_info.set_first_loaded_at(current_timestamp());
 
         // The wallet already has accounts created according to the provided options
@@ -276,8 +275,7 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
         })?;
 
         // Add the wallet to the manager
-        let mut managed_info = T::from_wallet(&final_wallet);
-        managed_info.set_birth_height(birth_height);
+        let mut managed_info = T::from_wallet(&final_wallet, birth_height);
         managed_info.set_first_loaded_at(current_timestamp());
 
         self.wallets.insert(wallet_id, final_wallet);
@@ -311,8 +309,7 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
         }
 
         // Create managed wallet info
-        let mut managed_info = T::from_wallet(&wallet);
-        managed_info.set_birth_height(self.last_processed_height());
+        let mut managed_info = T::from_wallet(&wallet, self.last_processed_height());
         managed_info.set_first_loaded_at(current_timestamp());
 
         self.wallets.insert(wallet_id, wallet);
@@ -352,8 +349,7 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
         }
 
         // Create managed wallet info
-        let mut managed_info = T::from_wallet(&wallet);
-        managed_info.set_birth_height(self.last_processed_height());
+        let mut managed_info = T::from_wallet(&wallet, self.last_processed_height());
         managed_info.set_first_loaded_at(current_timestamp());
 
         self.wallets.insert(wallet_id, wallet);
@@ -400,8 +396,7 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
         }
 
         // Create managed wallet info
-        let mut managed_info = T::from_wallet(&wallet);
-        managed_info.set_birth_height(self.last_processed_height());
+        let mut managed_info = T::from_wallet(&wallet, self.last_processed_height());
         managed_info.set_first_loaded_at(current_timestamp());
 
         self.wallets.insert(wallet_id, wallet);
@@ -442,11 +437,10 @@ impl<T: WalletInfoInterface + Send + Sync + 'static> WalletManager<T> {
             return Err(WalletError::WalletExists(wallet_id));
         }
 
-        // Create managed wallet info from the imported wallet
-        let mut managed_info = T::from_wallet(&wallet);
-
-        // Use the current height as the birth height since we don't know when it was originally created
-        managed_info.set_birth_height(self.last_processed_height());
+        // Create managed wallet info from the imported wallet, using the manager's
+        // current aggregated last-processed height as the fallback birth height
+        // since the serialized form does not preserve it.
+        let mut managed_info = T::from_wallet(&wallet, self.last_processed_height());
         managed_info.set_first_loaded_at(current_timestamp());
 
         self.wallets.insert(wallet_id, wallet);

key-wallet-manager/tests/integration_test.rs

@@ -181,36 +181,41 @@ fn test_block_height_tracking() {
         .create_wallet_from_mnemonic(
             &mnemonic2.to_string(),
             "",
-            0,
+            5000,
             WalletAccountCreationOptions::Default,
         )
         .unwrap();
 
     assert_eq!(manager.wallet_count(), 2);
 
-    // Both wallets initialized with `synced_height = birth_height - 1 = 0`,
-    // so neither has been processed past genesis.
-    for wallet_info in manager.get_all_wallet_infos().values() {
-        assert_eq!(wallet_info.last_processed_height(), 0);
-        assert_eq!(wallet_info.synced_height(), 0);
-    }
+    // wallet1 was created with birth_height = 0 so its sync checkpoint stays at 0;
+    // wallet2 was created with birth_height = 5000 and is seeded to birth_height - 1.
+    let wallet_info1 = manager.get_wallet_info(&wallet_id1).unwrap();
+    let wallet_info2 = manager.get_wallet_info(&wallet_id2).unwrap();
+    assert_eq!(wallet_info1.last_processed_height(), 0);
+    assert_eq!(wallet_info1.synced_height(), 0);
+    assert_eq!(wallet_info2.last_processed_height(), 4999);
+    assert_eq!(wallet_info2.synced_height(), 4999);
+    // Manager aggregates: synced_height is the min, last_processed_height is the max.
+    assert_eq!(manager.synced_height(), 0);
+    assert_eq!(manager.last_processed_height(), 4999);
 
     // Per-wallet last-processed updates only touch the addressed wallet.
     manager.update_wallet_last_processed_height(&wallet_id1, 12345);
     assert_eq!(manager.last_processed_height(), 12345);
     let wallet_info1 = manager.get_wallet_info(&wallet_id1).unwrap();
     let wallet_info2 = manager.get_wallet_info(&wallet_id2).unwrap();
     assert_eq!(wallet_info1.last_processed_height(), 12345);
-    assert_eq!(wallet_info2.last_processed_height(), 0);
+    assert_eq!(wallet_info2.last_processed_height(), 4999);
 
     // Per-wallet synced-height updates only touch the addressed wallet.
     manager.update_wallet_synced_height(&wallet_id1, 12000);
     let wallet_info1 = manager.get_wallet_info(&wallet_id1).unwrap();
     let wallet_info2 = manager.get_wallet_info(&wallet_id2).unwrap();
     assert_eq!(wallet_info1.synced_height(), 12000);
-    assert_eq!(wallet_info2.synced_height(), 0);
-    // Aggregate `synced_height()` is `min` across wallets, so wallet 2 holds it at 0.
-    assert_eq!(manager.synced_height(), 0);
+    assert_eq!(wallet_info2.synced_height(), 4999);
+    // Aggregate `synced_height()` is `min` across wallets, so wallet 2 holds it at 4999.
+    assert_eq!(manager.synced_height(), 4999);
 
     // Advance wallet 2 too. Aggregate min jumps to wallet 2's new value.
     manager.update_wallet_synced_height(&wallet_id2, 11000);

key-wallet-manager/tests/test_serialized_wallets.rs

@@ -2,6 +2,7 @@
 #[cfg(test)]
 mod tests {
     use key_wallet::wallet::initialization::WalletAccountCreationOptions;
+    use key_wallet::wallet::managed_wallet_info::wallet_info_interface::WalletInfoInterface;
     use key_wallet::wallet::managed_wallet_info::ManagedWalletInfo;
     use key_wallet::Network;
     use key_wallet_manager::WalletManager;
@@ -26,6 +27,12 @@ mod tests {
         assert!(!bytes.is_empty());
         println!("Full wallet ID: {}", hex::encode(wallet_id));
 
+        // The wallet's sync checkpoint should be seeded to birth_height - 1.
+        let info = manager.get_wallet_info(&wallet_id).unwrap();
+        assert_eq!(info.birth_height(), 100_000);
+        assert_eq!(info.synced_height(), 99_999);
+        assert_eq!(info.last_processed_height(), 99_999);
+
         // Test 2: Create watch-only wallet (no private keys)
         let mut manager2 = WalletManager::<ManagedWalletInfo>::new(Network::Testnet);
         let result = manager2.create_wallet_from_mnemonic_return_serialized_bytes(

key-wallet/src/test_utils/wallet.rs

@@ -31,7 +31,7 @@ impl TestWalletContext {
         let wallet = Wallet::new_random(Network::Testnet, WalletAccountCreationOptions::Default)
             .expect("Should create wallet");
         let mut managed_wallet =
-            ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+            ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
         let xpub = wallet
             .accounts

key-wallet/src/transaction_checking/transaction_router/tests/identity_transactions.rs

@@ -44,7 +44,7 @@ async fn test_identity_registration_account_routing() {
     wallet.add_account(account_type, None).expect("Failed to add account to wallet");
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get the identity registration account
     let account = wallet
@@ -155,7 +155,7 @@ async fn test_normal_payment_to_identity_address_not_detected() {
     let mut wallet = Wallet::new_random(network, WalletAccountCreationOptions::Default)
         .expect("Failed to create wallet with default options");
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     let account = wallet
         .accounts

key-wallet/src/transaction_checking/transaction_router/tests/provider.rs

@@ -136,10 +136,10 @@ async fn test_provider_registration_transaction_routing_check_owner_only() {
         .expect("Failed to create wallet with default options");
 
     let mut other_managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string(), 0);
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get addresses from provider accounts
     let managed_owner = managed_wallet_info
@@ -271,10 +271,10 @@ async fn test_provider_registration_transaction_routing_check_voting_only() {
         .expect("Failed to create wallet with default options");
 
     let mut other_managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string(), 0);
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get addresses from provider accounts
     let owner_address = other_managed_wallet_info
@@ -406,10 +406,10 @@ async fn test_provider_registration_transaction_routing_check_operator_only() {
         .expect("Failed to create wallet with default options");
 
     let mut other_managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string(), 0);
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get addresses from provider accounts
     let owner_address = other_managed_wallet_info
@@ -587,10 +587,10 @@ async fn test_provider_registration_transaction_routing_check_platform_only() {
         .expect("Failed to create wallet with default options");
 
     let mut other_managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&other_wallet, "Other".to_string(), 0);
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get addresses from provider accounts
     let owner_address = other_managed_wallet_info
@@ -785,7 +785,7 @@ async fn test_provider_update_registrar_with_voting_and_operator() {
         .expect("Failed to create wallet with default options");
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get voting address
     let voting_address = managed_wallet_info
@@ -858,7 +858,7 @@ async fn test_provider_revocation_classification_and_routing() {
         .expect("Failed to create wallet with default options");
 
     let mut managed_wallet_info =
-        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string());
+        ManagedWalletInfo::from_wallet_with_name(&wallet, "Test".to_string(), 0);
 
     // Get a standard address for collateral return
     let account = wallet