tests corrrectly use a temp dir

Author: ZocoLini

dash-spv/src/network/manager.rs

@@ -80,6 +80,7 @@ impl PeerNetworkManager {
 
         let discovery = DnsDiscovery::new().await?;
         let data_dir = config.storage_path.clone().unwrap_or_else(|| PathBuf::from("."));
+
         let peer_store = PersistentPeerStorage::open(data_dir.clone()).await?;
 
         let reputation_manager = Arc::new(PeerReputationManager::new());

dash-spv/src/storage/peers.rs

@@ -55,8 +55,10 @@ impl PersistentPeerStorage {
 #[async_trait]
 impl PersistentStorage for PersistentPeerStorage {
     async fn open(storage_path: impl Into<PathBuf> + Send) -> StorageResult<Self> {
+        let storage_path = storage_path.into();
+
         Ok(PersistentPeerStorage {
-            storage_path: storage_path.into().join(Self::FOLDER_NAME),
+            storage_path: storage_path.join(Self::FOLDER_NAME),
         })
     }
 

dash-spv/tests/handshake_test.rs

@@ -73,7 +73,8 @@ async fn test_handshake_timeout() {
 
 #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
 async fn test_network_manager_creation() {
-    let config = ClientConfig::new(Network::Dash);
+    let temp_dir = tempfile::TempDir::new().expect("Failed to create temporary directory");
+    let config = ClientConfig::new(Network::Dash).with_storage_path(temp_dir.path().to_path_buf());
     let network = PeerNetworkManager::new(&config).await;
 
     assert!(network.is_ok(), "Network manager creation should succeed");

dash-spv/tests/header_sync_test.rs

@@ -261,9 +261,11 @@ async fn test_header_sync_performance() {
 #[tokio::test]
 async fn test_header_sync_with_client_integration() {
     let _ = env_logger::try_init();
+    let temp_dir = tempfile::TempDir::new().expect("Failed to create temporary directory");
 
     // Test header sync integration with the full client
     let config = ClientConfig::new(Network::Dash)
+        .with_storage_path(temp_dir.path().to_path_buf())
         .with_validation_mode(ValidationMode::Basic)
         .with_connection_timeout(Duration::from_secs(10));
 

dash-spv/tests/wallet_integration_test.rs

@@ -15,7 +15,11 @@ use key_wallet_manager::wallet_manager::WalletManager;
 /// Create a test SPV client with memory storage for integration testing.
 async fn create_test_client(
 ) -> DashSpvClient<WalletManager<ManagedWalletInfo>, PeerNetworkManager, DiskStorageManager> {
-    let config = ClientConfig::testnet().without_filters().without_masternodes();
+    let temp_dir = tempfile::TempDir::new().expect("Failed to create temporary directory");
+    let config = ClientConfig::testnet()
+        .without_filters()
+        .without_masternodes()
+        .with_storage_path(temp_dir.path().to_path_buf());
 
     // Create network manager
     let network_manager = PeerNetworkManager::new(&config).await.unwrap();