refactor: Make flow control syncing default and drop the no flow parts

Author: xdustinface

dash-spv/src/client/config.rs

@@ -78,42 +78,9 @@ pub struct ClientConfig {
     /// Maximum concurrent filter requests (default: 8).
     pub max_concurrent_filter_requests: usize,
 
-    /// Enable flow control for filter requests (default: true).
-    pub enable_filter_flow_control: bool,
-
     /// Delay between filter requests in milliseconds (default: 50).
     pub filter_request_delay_ms: u64,
 
-    /// Enable automatic CFHeader gap detection and restart
-    pub enable_cfheader_gap_restart: bool,
-
-    /// Interval for checking CFHeader gaps (seconds)
-    pub cfheader_gap_check_interval_secs: u64,
-
-    /// Cooldown between CFHeader restart attempts (seconds)  
-    pub cfheader_gap_restart_cooldown_secs: u64,
-
-    /// Maximum CFHeader gap restart attempts
-    pub max_cfheader_gap_restart_attempts: u32,
-
-    /// Enable automatic filter gap detection and restart
-    pub enable_filter_gap_restart: bool,
-
-    /// Interval for checking filter gaps (seconds)
-    pub filter_gap_check_interval_secs: u64,
-
-    /// Minimum filter gap size to trigger restart (blocks)
-    pub min_filter_gap_size: u32,
-
-    /// Cooldown between filter restart attempts (seconds)
-    pub filter_gap_restart_cooldown_secs: u64,
-
-    /// Maximum filter gap restart attempts
-    pub max_filter_gap_restart_attempts: u32,
-
-    /// Maximum number of filters to sync in a single gap sync batch
-    pub max_filter_gap_sync_size: u32,
-
     // Mempool configuration
     /// Enable tracking of unconfirmed (mempool) transactions.
     pub enable_mempool_tracking: bool,
@@ -159,9 +126,6 @@ pub struct ClientConfig {
     /// Maximum concurrent CFHeaders requests for parallel sync (default: 50).
     pub max_concurrent_cfheaders_requests_parallel: usize,
 
-    /// Enable flow control for CFHeaders requests (default: true).
-    pub enable_cfheaders_flow_control: bool,
-
     /// Timeout for CFHeaders requests in seconds (default: 30).
     pub cfheaders_request_timeout_secs: u64,
 
@@ -210,18 +174,7 @@ impl Default for ClientConfig {
             log_level: "info".to_string(),
             user_agent: None,
             max_concurrent_filter_requests: 16,
-            enable_filter_flow_control: true,
             filter_request_delay_ms: 0,
-            enable_cfheader_gap_restart: true,
-            cfheader_gap_check_interval_secs: 15,
-            cfheader_gap_restart_cooldown_secs: 30,
-            max_cfheader_gap_restart_attempts: 5,
-            enable_filter_gap_restart: true,
-            filter_gap_check_interval_secs: 20,
-            min_filter_gap_size: 10,
-            filter_gap_restart_cooldown_secs: 30,
-            max_filter_gap_restart_attempts: 5,
-            max_filter_gap_sync_size: 50000,
             // Mempool defaults
             enable_mempool_tracking: true,
             mempool_strategy: MempoolStrategy::FetchAll,
@@ -243,7 +196,6 @@ impl Default for ClientConfig {
             wallet_creation_time: None,
             // CFHeaders flow control defaults
             max_concurrent_cfheaders_requests_parallel: 50,
-            enable_cfheaders_flow_control: true,
             cfheaders_request_timeout_secs: 30,
             max_cfheaders_retries: 3,
             // QRInfo defaults (simplified per plan)
@@ -341,12 +293,6 @@ impl ClientConfig {
         self
     }
 
-    /// Enable or disable filter flow control.
-    pub fn with_filter_flow_control(mut self, enabled: bool) -> Self {
-        self.enable_filter_flow_control = enabled;
-        self
-    }
-
     /// Set delay between filter requests.
     pub fn with_filter_request_delay(mut self, delay_ms: u64) -> Self {
         self.filter_request_delay_ms = delay_ms;

dash-spv/src/client/config_test.rs

@@ -28,7 +28,6 @@ mod tests {
         assert!(config.enable_persistence);
         assert_eq!(config.log_level, "info");
         assert_eq!(config.max_concurrent_filter_requests, 16);
-        assert!(config.enable_filter_flow_control);
         assert_eq!(config.filter_request_delay_ms, 0);
 
         // Mempool defaults
@@ -66,7 +65,6 @@ mod tests {
             .with_connection_timeout(Duration::from_secs(10))
             .with_log_level("debug")
             .with_max_concurrent_filter_requests(32)
-            .with_filter_flow_control(false)
             .with_filter_request_delay(100)
             .with_mempool_tracking(MempoolStrategy::BloomFilter)
             .with_max_mempool_transactions(500)
@@ -80,7 +78,6 @@ mod tests {
         assert_eq!(config.connection_timeout, Duration::from_secs(10));
         assert_eq!(config.log_level, "debug");
         assert_eq!(config.max_concurrent_filter_requests, 32);
-        assert!(!config.enable_filter_flow_control);
         assert_eq!(config.filter_request_delay_ms, 100);
 
         // Mempool settings
@@ -196,28 +193,6 @@ mod tests {
 
     // Removed selective strategy validation test; Selective variant no longer exists
 
-    #[test]
-    fn test_cfheader_gap_settings() {
-        let config = ClientConfig::default();
-
-        assert!(config.enable_cfheader_gap_restart);
-        assert_eq!(config.cfheader_gap_check_interval_secs, 15);
-        assert_eq!(config.cfheader_gap_restart_cooldown_secs, 30);
-        assert_eq!(config.max_cfheader_gap_restart_attempts, 5);
-    }
-
-    #[test]
-    fn test_filter_gap_settings() {
-        let config = ClientConfig::default();
-
-        assert!(config.enable_filter_gap_restart);
-        assert_eq!(config.filter_gap_check_interval_secs, 20);
-        assert_eq!(config.min_filter_gap_size, 10);
-        assert_eq!(config.filter_gap_restart_cooldown_secs, 30);
-        assert_eq!(config.max_filter_gap_restart_attempts, 5);
-        assert_eq!(config.max_filter_gap_sync_size, 50000);
-    }
-
     #[test]
     fn test_request_control_defaults() {
         let config = ClientConfig::default();

dash-spv/src/client/filter_sync.rs

@@ -17,7 +17,6 @@
 //!
 //! - `block_processor.rs` (649 lines) - Block processing and validation
 //! - `config.rs` (484 lines) - Client configuration
-//! - `filter_sync.rs` (171 lines) - Filter synchronization
 //! - `message_handler.rs` (585 lines) - Network message handling
 //! - `status_display.rs` (242 lines) - Status display formatting
 //!
@@ -35,7 +34,6 @@
 // Existing extracted modules
 pub mod block_processor;
 pub mod config;
-pub mod filter_sync;
 pub mod message_handler;
 pub mod status_display;
 
@@ -53,7 +51,6 @@ mod transactions;
 // Re-export public types from extracted modules
 pub use block_processor::{BlockProcessingTask, BlockProcessor};
 pub use config::ClientConfig;
-pub use filter_sync::FilterSyncCoordinator;
 pub use message_handler::MessageHandler;
 pub use status_display::StatusDisplay;