refactor(key-wallet): add all_funding_accounts(_mut) and drop in-loop as_funds() filters

Five funds-only callsites in `wallet_info_interface.rs` were iterating
`all_accounts()` and filtering each ref via `as_funds()` / `as_funds_mut()`
inside the loop body — pure noise, since balance / UTXO state only ever
lives on Standard / CoinJoin / DashPay accounts.

Add focused accessors on `ManagedAccountCollection`:

- `all_funding_accounts(&self) -> Vec<&ManagedCoreFundsAccount>`
- `all_funding_accounts_mut(&mut self) -> Vec<&mut ManagedCoreFundsAccount>`

Migrate `account_balances`, `utxos`, `update_balance`, `immature_transactions`,
and `matured_coinbase_records` to use them. `monitored_addresses`,
`transaction_history`, `monitor_revision`, and `mark_instant_send_utxos`
keep using `all_accounts(_mut)` — they legitimately span both variants.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: QuantumExplorer

key-wallet/src/managed_account/managed_account_collection.rs

@@ -1152,6 +1152,34 @@ impl ManagedAccountCollection {
         accounts
     }
 
+    /// Get all funds-bearing accounts (Standard BIP44/32, CoinJoin, DashPay).
+    ///
+    /// Use this from callsites that operate on balance / UTXO state — keys-only
+    /// accounts (identity, asset-lock, provider) don't track those, so iterating
+    /// [`Self::all_accounts`] and filtering via [`ManagedAccountRef::as_funds`]
+    /// in those callsites is just noise.
+    pub fn all_funding_accounts(&self) -> Vec<&ManagedCoreFundsAccount> {
+        let mut accounts = Vec::new();
+        accounts.extend(self.standard_bip44_accounts.values());
+        accounts.extend(self.standard_bip32_accounts.values());
+        accounts.extend(self.coinjoin_accounts.values());
+        accounts.extend(self.dashpay_receival_accounts.values());
+        accounts.extend(self.dashpay_external_accounts.values());
+        accounts
+    }
+
+    /// Get all funds-bearing accounts mutably. See [`Self::all_funding_accounts`]
+    /// for which account types are visited.
+    pub fn all_funding_accounts_mut(&mut self) -> Vec<&mut ManagedCoreFundsAccount> {
+        let mut accounts = Vec::new();
+        accounts.extend(self.standard_bip44_accounts.values_mut());
+        accounts.extend(self.standard_bip32_accounts.values_mut());
+        accounts.extend(self.coinjoin_accounts.values_mut());
+        accounts.extend(self.dashpay_receival_accounts.values_mut());
+        accounts.extend(self.dashpay_external_accounts.values_mut());
+        accounts
+    }
+
     /// Get the count of accounts
     pub fn count(&self) -> usize {
         self.all_accounts().len()

key-wallet/src/wallet/managed_wallet_info/wallet_info_interface.rs

@@ -78,12 +78,9 @@ pub trait WalletInfoInterface: Sized + WalletTransactionChecker + ManagedAccount
     /// balance.
     fn account_balances(&self) -> BTreeMap<AccountType, WalletCoreBalance> {
         self.accounts()
-            .all_accounts()
+            .all_funding_accounts()
             .iter()
-            .filter_map(|acc| {
-                let funds = acc.as_funds()?;
-                Some((funds.managed_account_type().to_account_type(), funds.balance))
-            })
+            .map(|funds| (funds.managed_account_type().to_account_type(), funds.balance))
             .collect()
     }
 
@@ -196,10 +193,8 @@ impl WalletInfoInterface for ManagedWalletInfo {
 
     fn utxos(&self) -> BTreeSet<&Utxo> {
         let mut utxos = BTreeSet::new();
-        for account in self.accounts.all_accounts() {
-            if let Some(funds) = account.as_funds() {
-                utxos.extend(funds.utxos.values());
-            }
+        for account in self.accounts.all_funding_accounts() {
+            utxos.extend(account.utxos.values());
         }
         utxos
     }
@@ -215,14 +210,12 @@ impl WalletInfoInterface for ManagedWalletInfo {
     }
 
     fn update_balance(&mut self) {
+        // Only funds-bearing accounts contribute to the wallet balance.
         let mut balance = WalletCoreBalance::default();
         let last_processed_height = self.last_processed_height();
-        for mut account in self.accounts.all_accounts_mut() {
-            // Only funds-bearing accounts contribute to the wallet balance.
-            if let Some(funds) = account.as_funds_mut() {
-                funds.update_balance(last_processed_height);
-                balance += funds.balance;
-            }
+        for funds in self.accounts.all_funding_accounts_mut() {
+            funds.update_balance(last_processed_height);
+            balance += funds.balance;
         }
         self.balance = balance;
     }
@@ -244,14 +237,10 @@ impl WalletInfoInterface for ManagedWalletInfo {
     }
 
     fn immature_transactions(&self) -> Vec<Transaction> {
-        let mut immature_txids: BTreeSet<Txid> = BTreeSet::new();
-
         // Coinbase UTXOs only live on funds-bearing accounts.
-        for account in self.accounts.all_accounts() {
-            let Some(funds) = account.as_funds() else {
-                continue;
-            };
-            for utxo in funds.utxos.values() {
+        let mut immature_txids: BTreeSet<Txid> = BTreeSet::new();
+        for account in self.accounts.all_funding_accounts() {
+            for utxo in account.utxos.values() {
                 if utxo.is_coinbase && !utxo.is_mature(self.last_processed_height()) {
                     immature_txids.insert(utxo.outpoint.txid);
                 }
@@ -260,11 +249,8 @@ impl WalletInfoInterface for ManagedWalletInfo {
 
         // Look up the matching transaction records on the same funds accounts.
         let mut transactions = Vec::new();
-        for account in self.accounts.all_accounts() {
-            let Some(funds) = account.as_funds() else {
-                continue;
-            };
-            for (txid, record) in funds.transactions() {
+        for account in self.accounts.all_funding_accounts() {
+            for (txid, record) in account.transactions() {
                 if immature_txids.contains(txid) {
                     transactions.push(record.transaction.clone());
                 }
@@ -291,13 +277,10 @@ impl WalletInfoInterface for ManagedWalletInfo {
         if new_height <= old_height {
             return Vec::new();
         }
+        // Coinbase records only land on funds-bearing accounts.
         let mut matured = Vec::new();
-        for account in self.accounts.all_accounts() {
-            // Coinbase records only land on funds-bearing accounts.
-            let Some(funds) = account.as_funds() else {
-                continue;
-            };
-            for record in funds.transactions().values() {
+        for account in self.accounts.all_funding_accounts() {
+            for record in account.transactions().values() {
                 if !record.transaction.is_coin_base() {
                     continue;
                 }