drop unnecesary codebase complexity removing the bincode usage where is not needed

in the key-wallet crate

Author: ZocoLini

key-wallet-ffi/Cargo.toml

@@ -13,9 +13,9 @@ name = "key_wallet_ffi"
 crate-type = ["cdylib", "staticlib", "lib"]
 
 [features]
-default = ["bincode", "eddsa", "bls", "bip38"]
+default = ["serde", "eddsa", "bls", "bip38"]
 bip38 = ["key-wallet/bip38"]
-bincode = ["key-wallet/bincode"]
+serde = ["key-wallet/serde"]
 eddsa = ["dashcore/eddsa", "key-wallet/eddsa"]
 bls = ["dashcore/bls", "key-wallet/bls"]
 

key-wallet-ffi/src/wallet_manager.rs

@@ -277,7 +277,7 @@ pub unsafe extern "C" fn wallet_manager_add_wallet_from_mnemonic(
 /// - `error` must be a valid pointer to an FFIError structure or null
 /// - The caller must ensure all pointers remain valid for the duration of this call
 /// - The caller must free the returned wallet_bytes using wallet_manager_free_wallet_bytes()
-#[cfg(feature = "bincode")]
+#[cfg(feature = "serde")]
 #[no_mangle]
 pub unsafe extern "C" fn wallet_manager_add_wallet_from_mnemonic_return_serialized_bytes(
     manager: *mut FFIWalletManager,
@@ -397,7 +397,7 @@ pub unsafe extern "C" fn wallet_manager_add_wallet_from_mnemonic_return_serializ
 /// - `bytes_len` must match the original allocation size
 /// - The pointer must not be used after calling this function
 /// - This function must only be called once per buffer
-#[cfg(feature = "bincode")]
+#[cfg(feature = "serde")]
 #[no_mangle]
 pub unsafe extern "C" fn wallet_manager_free_wallet_bytes(wallet_bytes: *mut u8, bytes_len: usize) {
     if !wallet_bytes.is_null() && bytes_len > 0 {
@@ -422,7 +422,7 @@ pub unsafe extern "C" fn wallet_manager_free_wallet_bytes(wallet_bytes: *mut u8,
 /// - `wallet_id_out` must be a valid pointer to a 32-byte array that will receive the wallet ID
 /// - `error` must be a valid pointer to an FFIError structure or null
 /// - The caller must ensure all pointers remain valid for the duration of this call
-#[cfg(feature = "bincode")]
+#[cfg(feature = "serde")]
 #[no_mangle]
 pub unsafe extern "C" fn wallet_manager_import_wallet_from_bytes(
     manager: *mut FFIWalletManager,

key-wallet-ffi/src/wallet_manager_serialization_tests.rs

@@ -1,6 +1,6 @@
 //! Tests for wallet serialization FFI functions
 
-#[cfg(all(test, feature = "bincode"))]
+#[cfg(all(test, feature = "serde"))]
 mod tests {
     use crate::error::{FFIError, FFIErrorCode};
     use crate::types::FFIWalletAccountCreationOptions;

key-wallet-ffi/src/wallet_manager_tests.rs

@@ -864,7 +864,7 @@ mod tests {
         }
     }
 
-    #[cfg(feature = "bincode")]
+    #[cfg(feature = "serde")]
     #[test]
     fn test_create_wallet_from_mnemonic_return_serialized_bytes() {
         let mut error = FFIError::success();
@@ -1062,7 +1062,7 @@ mod tests {
         }
     }
 
-    #[cfg(feature = "bincode")]
+    #[cfg(feature = "serde")]
     #[test]
     fn test_serialized_wallet_across_managers() {
         let mut error = FFIError::success();

key-wallet-ffi/tests/test_import_wallet.rs

@@ -1,6 +1,6 @@
 //! Test for wallet import from bytes via FFI
 
-#[cfg(feature = "bincode")]
+#[cfg(feature = "serde")]
 #[cfg(test)]
 mod tests {
     use key_wallet_ffi::error::{FFIError, FFIErrorCode};

key-wallet/Cargo.toml

@@ -11,8 +11,7 @@ license = "CC0-1.0"
 [features]
 default = ["std"]
 std = ["secp256k1/std", "bip39/std", "getrandom", "rand"]
-serde = ["dep:serde", "dep:serde_json", "dashcore_hashes/serde", "secp256k1/serde", "dashcore/serde"]
-bincode = ["serde", "dep:bincode", "dep:bincode_derive", "dashcore_hashes/bincode", "dashcore/bincode"]
+serde = ["dep:serde", "dep:bincode", "dashcore_hashes/serde", "secp256k1/serde", "dashcore/serde"]
 bip38 = ["scrypt", "aes", "bs58", "rand"]
 eddsa = ["dashcore/eddsa"]
 bls = ["dashcore/bls"]
@@ -24,7 +23,6 @@ dashcore_hashes = { path = "../hashes" }
 dashcore = { path="../dash" }
 secp256k1 = { version = "0.30.0", default-features = false, features = ["hashes", "recovery"] }
 bip39 = { version = "2.2.0", default-features = false, features = ["chinese-simplified", "chinese-traditional", "czech", "french", "italian", "japanese", "korean", "portuguese", "spanish", "zeroize"] }
-serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
 base58ck = { version = "0.1.0", default-features = false }
 bitflags = { version = "2.6", default-features = false }
 getrandom = { version = "0.2", optional = true }
@@ -35,10 +33,9 @@ sha2 = { version = "0.10", default-features = false }
 bs58 = { version = "0.5", default-features = false, features = ["check", "alloc"], optional = true }
 rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true }
 # Serialization
-bincode = { version = "2.0.1", optional = true }
-bincode_derive = { version = "2.0.1", optional = true }
+serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
+bincode = { version = "2.0.1", default-features = false, features = ["serde"], optional = true }
 base64 = { version = "0.22", optional = true }
-serde_json = { version = "1.0", optional = true }
 hex = { version = "0.4"}
 zeroize = { version = "1.8", features = ["derive"] }
 tracing = "0.1"
@@ -49,5 +46,5 @@ rayon = { version = "1.11" }
 [dev-dependencies]
 dashcore = { path="../dash", features = ["test-utils"] }
 hex = "0.4"
-key-wallet = { path = ".", features = ["test-utils", "bip38", "serde", "bincode", "eddsa", "bls"] }
+key-wallet = { path = ".", features = ["test-utils", "bip38", "serde", "eddsa", "bls"] }
 test-case = "3.3"

key-wallet/src/account/account_collection.rs

@@ -4,8 +4,6 @@
 
 use alloc::collections::BTreeMap;
 use alloc::vec::Vec;
-#[cfg(feature = "bincode")]
-use bincode_derive::{Decode, Encode};
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
 
@@ -21,7 +19,6 @@ pub type DashpayContactIdentityId = [u8; 32];
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct DashpayAccountKey {
     pub index: u32,
     pub user_identity_id: DashpayOurUserIdentityId,
@@ -31,7 +28,6 @@ pub struct DashpayAccountKey {
 /// Key for Platform Payment accounts (DIP-17)
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct PlatformPaymentAccountKey {
     /// Account index (hardened)
     pub account: u32,
@@ -42,7 +38,6 @@ pub struct PlatformPaymentAccountKey {
 /// Collection of accounts organized by type
 #[derive(Debug, Clone, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct AccountCollection {
     /// Standard BIP44 accounts by index
     pub standard_bip44_accounts: BTreeMap<u32, Account>,

key-wallet/src/account/account_type.rs

@@ -8,15 +8,12 @@ use crate::transaction_checking::transaction_router::{
     AccountTypeToCheck, PlatformAccountConversionError,
 };
 use crate::Network;
-#[cfg(feature = "bincode")]
-use bincode_derive::{Decode, Encode};
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
 
 /// Account types supported by the wallet
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub enum StandardAccountType {
     /// Standard BIP44 account for regular transactions m/44'/coin_type'/account'/x/x
     #[default]
@@ -28,7 +25,6 @@ pub enum StandardAccountType {
 /// Account types supported by the wallet
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub enum AccountType {
     /// Standard BIP44 account for regular transactions
     Standard {

key-wallet/src/account/bls_account.rs

@@ -17,8 +17,6 @@ use dashcore::Address;
 use serde::{Deserialize, Serialize};
 
 use crate::bip32::{ChainCode, Fingerprint};
-#[cfg(feature = "bincode")]
-use bincode_derive::{Decode, Encode};
 use dashcore::blsful::{Bls12381G2Impl, SerializationFormat};
 
 use crate::account::derivation::AccountDerivation;
@@ -28,7 +26,6 @@ pub use dashcore::blsful::SecretKey;
 /// BLS account structure for Platform and masternode operations
 #[derive(Debug, Clone)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct BLSAccount {
     /// Wallet id (stored as Vec for serialization)
     pub parent_wallet_id: Option<Vec<u8>>,
@@ -164,21 +161,6 @@ impl BLSAccount {
         watch_only.is_watch_only = true;
         watch_only
     }
-
-    /// Serialize account to bytes
-    #[cfg(feature = "bincode")]
-    pub fn serialize(&self) -> Result<Vec<u8>> {
-        bincode::encode_to_vec(self, bincode::config::standard())
-            .map_err(|e| Error::Serialization(e.to_string()))
-    }
-
-    /// Deserialize account from bytes
-    #[cfg(feature = "bincode")]
-    pub fn deserialize(data: &[u8]) -> Result<Self> {
-        bincode::decode_from_slice(data, bincode::config::standard())
-            .map(|(account, _)| account)
-            .map_err(|e| Error::Serialization(e.to_string()))
-    }
 }
 
 impl AccountTrait for BLSAccount {

key-wallet/src/account/coinjoin.rs

@@ -3,15 +3,12 @@
 //! This module contains structures for managing CoinJoin address pools.
 
 use crate::managed_account::address_pool::AddressPool;
-#[cfg(feature = "bincode")]
-use bincode_derive::{Decode, Encode};
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
 
 /// CoinJoin-specific address pools
 #[derive(Debug, Clone)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct CoinJoinPools {
     /// CoinJoin receive addresses
     pub external: AddressPool,