chore: merge v0.42-dev into feat/per-wallet-filter-scan

[QuantumExplorer]

Resolves the merge conflicts blocking #694 by merging the latest v0.42-dev into feat/per-wallet-filter-scan. Once this lands on the feature branch, #694 will go from CONFLICTING to mergeable.

Source of conflicts

v0.42-dev advanced ahead of the feature branch by #695 (masternode seed refresh, no overlap) and #696 (atomic wallet events). The wallet-events refactor changed the same files that #694 restructured around per-wallet processing:

File	Conflict
key-wallet-manager/src/lib.rs	feat branch emits events from check_transaction_in_wallets; #696 moved emission to callers so events can carry the post-balance
key-wallet-manager/src/process_block.rs	feat branch added per-wallet API (process_block_for_wallets, wallets_behind, update_wallet_synced_height, …); #696 added finalize_block_advance and replaced BalanceUpdated/TransactionReceived/TransactionStatusChanged with TransactionDetected/TransactionInstantLocked/BlockProcessed/SyncHeightAdvanced
key-wallet-manager/src/event_tests.rs	#696 rewrote almost the entire file against the new event shapes, while the feat branch had updated several tests for the per-wallet API

Resolution

• lib.rs — drop the in-place event emission inside check_transaction_in_wallets (per feat: make wallet events atomic #696, callers emit after refreshing balance). Keep feat: per-wallet filter scan and runtime wallet catch-up #694's new_addresses BTreeMap<WalletId, _> so per-wallet attribution survives.
• process_block.rs —
  • process_block_for_wallets now collects per_wallet_inserted/per_wallet_updated per feat: make wallet events atomic #696 and calls finalize_block_advance(height, wallets, …) to emit BlockProcessed only for the listed wallets.
  • finalize_block_advance is parameterized on the wallet set, so the per-wallet API only advances/emits for those wallets. Wallets already at or past height skip the height bump but still refresh balance — preserving the rescan-without-going-backwards behavior introduced on the feat branch.
  • update_wallet_synced_height now emits SyncHeightAdvanced for the wallet that advanced (the per-wallet analog of feat: make wallet events atomic #696's update_synced_height).
  • update_wallet_last_processed_height delegates to finalize_block_advance over a single-wallet set, so it emits BlockProcessed when the balance moved (matching what feat: make wallet events atomic #696's deleted update_last_processed_height did, but for one wallet at a time).
  • Renamed test_process_block_emits_balance_updated → test_process_block_emits_block_processed; renamed/rewrote test_update_synced_height_* → test_update_wallet_synced_height_* against the per-wallet API.
• event_tests.rs — start from feat: make wallet events atomic #696's rewritten file, then adapt API calls:
  • manager.process_block(&block, h) → manager.process_block_for_wallets(&block, h, &BTreeSet::from([wallet_id]))
  • manager.update_synced_height(h) → manager.update_wallet_synced_height(&wallet_id, h)

Verification

• cargo build --workspace
• cargo fmt --all --check
• cargo clippy --workspace --all-targets -- -D warnings
• cargo test --workspace --exclude dash-spv --exclude dash-spv-ffi --exclude integration_test
• cargo test -p key-wallet-manager (30/30 unit tests pass, including all event tests)
• cargo test -p dash-spv --lib (404/404 pass)

Test plan

• CI green on the merge branch
• After merge, #694 shows MERGEABLE and CI is green there too
• Spot-check a WalletEvent::BlockProcessed event in an SPV integration test (e.g. dashd_sync) — it should carry per-wallet inserted/updated/matured/balance for the right wallet and only fire for wallets that were behind

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 72813451-ce4b-463a-8170-b234afcb7ef8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch merge/v0.42-dev-into-per-wallet-filter-scan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 67.39927% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.52%. Comparing base (541d0cf) to head (2efd17c).
⚠️ Report is 1 commits behind head on feat/per-wallet-filter-scan.

Files with missing lines	Patch %	Lines
dash-spv-ffi/src/bin/ffi_cli.rs	0.00%	55 Missing ⚠️
key-wallet-ffi/src/managed_account.rs	48.07%	54 Missing ⚠️
key-wallet-ffi/src/types.rs	36.36%	21 Missing ⚠️
key-wallet-manager/src/events.rs	0.00%	21 Missing ⚠️
dash-spv-ffi/src/callbacks.rs	81.35%	11 Missing ⚠️
key-wallet-ffi/src/account.rs	30.00%	7 Missing ⚠️
key-wallet-ffi/src/address_pool.rs	40.00%	3 Missing ⚠️
key-wallet-ffi/src/wallet.rs	33.33%	2 Missing ⚠️
key-wallet-manager/src/process_block.rs	98.14%	2 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs	90.90%	2 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##           feat/per-wallet-filter-scan     #698      +/-   ##
===============================================================
- Coverage                        70.65%   70.52%   -0.13%     
===============================================================
  Files                              320      320              
  Lines                            67692    67992     +300     
===============================================================
+ Hits                             47827    47952     +125     
- Misses                           19865    20040     +175     

Flag	Coverage Δ
core	75.81% <ø> (ø)
ffi	43.53% <45.16%> (-1.20%)	⬇️
rpc	20.00% <ø> (ø)
spv	87.38% <ø> (+0.09%)	⬆️
wallet	69.18% <90.63%> (+0.25%)	⬆️

Files with missing lines	Coverage Δ
key-wallet-ffi/src/account_collection.rs	55.93% <100.00%> (-0.70%)	⬇️
key-wallet-ffi/src/transaction_checking.rs	1.90% <ø> (ø)
key-wallet-manager/src/accessors.rs	53.65% <100.00%> (-10.38%)	⬇️
key-wallet-manager/src/lib.rs	62.88% <100.00%> (-0.25%)	⬇️
key-wallet-manager/src/test_helpers.rs	100.00% <ø> (ø)
key-wallet/src/managed_account/mod.rs	55.12% <100.00%> (+0.06%)	⬆️
...y-wallet/src/managed_account/transaction_record.rs	100.00% <100.00%> (ø)
...wallet/src/transaction_checking/account_checker.rs	67.02% <100.00%> (+0.51%)	⬆️
...-wallet/src/transaction_checking/wallet_checker.rs	99.34% <100.00%> (+0.05%)	⬆️
key-wallet-ffi/src/wallet.rs	25.22% <33.33%> (+2.72%)	⬆️
... and 9 more

... and 13 files with indirect coverage changes