Skip to content

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
QuantumExplorer wants to merge 11 commits into
base: v0.42-dev
Choose a base branch
from

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection

92d7568
Select commit
Loading
Failed to load commit list.
Draft

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection #716

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection
92d7568
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 0s

69.77% (-0.83%) compared to 5603fff

View this Pull Request on Codecov

69.77% (-0.83%) compared to 5603fff

Details

Codecov Report

❌ Patch coverage is 44.97937% with 1200 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.77%. Comparing base (5603fff) to head (92d7568).
⚠️ Report is 8 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
...t/src/managed_account/managed_core_keys_account.rs 44.71% 387 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 45.58% 382 Missing ⚠️
...-wallet/src/managed_account/managed_account_ref.rs 38.15% 154 Missing ⚠️
.../src/managed_account/managed_account_collection.rs 58.29% 88 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 70 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 20.48% 66 Missing ⚠️
...src/wallet/managed_wallet_info/managed_accounts.rs 13.63% 19 Missing ⚠️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 57.14% 18 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 55.55% 8 Missing ⚠️
key-wallet-ffi/src/managed_account_collection.rs 25.00% 6 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #716      +/-   ##
=============================================
- Coverage      70.59%   69.77%   -0.83%     
=============================================
  Files            320      322       +2     
  Lines          68246    69461    +1215     
=============================================
+ Hits           48181    48464     +283     
- Misses         20065    20997     +932
Files with missing lines Coverage Δ
dash-spv/src/sync/mempool/sync_manager.rs 98.72% <ø> (ø)
key-wallet-ffi/src/managed_wallet.rs 69.41% <100.00%> (-9.77%) ⬇️
key-wallet/src/account/mod.rs 62.79% <ø> (ø)
...allet/src/managed_account/managed_account_trait.rs 0.00% <ø> (ø)
...et/src/managed_account/managed_platform_account.rs 64.11% <ø> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 99.39% <100.00%> (+<0.01%) ⬆️
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.61% <100.00%> (ø)
...allet/managed_wallet_info/wallet_info_interface.rs 84.12% <97.14%> (+2.13%) ⬆️
key-wallet-ffi/src/managed_account_collection.rs 31.53% <25.00%> (+12.10%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 46.07% <55.55%> (-20.96%) ⬇️
... and 8 more

... and 16 files with indirect coverage changes

View more details on Codecov