refactor(key-wallet): drop unused first_loaded_at and total_transactions from WalletMetadata#719
Conversation
…ctions` from `WalletMetadata` Neither field is read by any consumer (FFI, SPV, key-wallet-manager, or key-wallet itself outside of the assertions removed here). `first_loaded_at` was only ever written via `set_first_loaded_at` from `WalletManager`; the trait methods, the field, and all six call sites are gone. `total_transactions` was only incremented in `check_core_transaction` and asserted on in tests; the increment, the helper, and the test assertions are gone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 30 minutes and 1 second.Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #719 +/- ##
=============================================
+ Coverage 70.57% 70.59% +0.01%
=============================================
Files 319 319
Lines 68211 68183 -28
=============================================
- Hits 48142 48132 -10
+ Misses 20069 20051 -18
|
Summary
first_loaded_atandtotal_transactionsfromWalletMetadata; neither field is read by any consumer.WalletInfoInterface::{first_loaded_at, set_first_loaded_at}, theManagedWalletInfo::increment_transactionshelper, and the sixWalletManagercall sites that wrotefirst_loaded_atafterfrom_wallet.wallet_checkerandwallet/mod.rsthat exercised the removed fields.Test plan
cargo build --workspacecargo test -p key-wallet -p key-wallet-managercargo clippy -p key-wallet -p key-wallet-manager --all-targets -- -D warningscargo fmt --check🤖 Generated with Claude Code