Skip to content

fix: preserve raw nTxType bytes on pre-DIP-0002 (version 0) transactions

68f5593
Select commit
Loading
Failed to load commit list.
Merged

fix: preserve raw nTxType bytes on pre-DIP-0002 transactions #726

fix: preserve raw nTxType bytes on pre-DIP-0002 (version 0) transactions
68f5593
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 4, 2026 in 0s

70.86% (+0.02%) compared to 7dc1225

View this Pull Request on Codecov

70.86% (+0.02%) compared to 7dc1225

Details

Codecov Report

❌ Patch coverage is 78.26087% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.86%. Comparing base (7dc1225) to head (68f5593).
⚠️ Report is 1 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
...c/blockdata/transaction/special_transaction/mod.rs 51.42% 17 Missing ⚠️
...src/transaction_checking/transaction_router/mod.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #726      +/-   ##
=============================================
+ Coverage      70.84%   70.86%   +0.02%     
=============================================
  Files            319      319              
  Lines          68184    68243      +59     
=============================================
+ Hits           48305    48361      +56     
- Misses         19879    19882       +3     
Files with missing lines Coverage Δ
dash/src/blockdata/transaction/mod.rs 86.76% <100.00%> (+0.58%) ⬆️
...ansaction/asset_unlock/unqualified_asset_unlock.rs 70.19% <100.00%> (ø)
dash/src/crypto/sighash.rs 65.61% <100.00%> (ø)
key-wallet/src/psbt/map/global.rs 51.26% <100.00%> (+0.62%) ⬆️
...src/transaction_checking/transaction_router/mod.rs 88.80% <78.57%> (-0.46%) ⬇️
...c/blockdata/transaction/special_transaction/mod.rs 38.16% <51.42%> (+2.64%) ⬆️

... and 3 files with indirect coverage changes