Skip to content

refactor(key-wallet)!: remove MnemonicWithPassphrase wallet type#747

Merged
xdustinface merged 3 commits into
v0.42-devfrom
claude/objective-mcnulty-c48584
May 8, 2026
Merged

refactor(key-wallet)!: remove MnemonicWithPassphrase wallet type#747
xdustinface merged 3 commits into
v0.42-devfrom
claude/objective-mcnulty-c48584

refactor: address review comments after passphrase removal

aab0e0b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2026 in 0s

71.78% (+0.47%) compared to 49c8c6d

View this Pull Request on Codecov

71.78% (+0.47%) compared to 49c8c6d

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (49c8c6d) to head (aab0e0b).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #747      +/-   ##
=============================================
+ Coverage      71.31%   71.78%   +0.47%     
=============================================
  Files            321      320       -1     
  Lines          70339    69411     -928     
=============================================
- Hits           50160    49828     -332     
+ Misses         20179    19583     -596     
Files with missing lines Coverage Δ
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% <ø> (ø)
dash-spv/src/main.rs 0.00% <ø> (ø)
key-wallet-ffi/src/account_collection.rs 74.64% <ø> (+26.97%) ⬆️
key-wallet-ffi/src/address_pool.rs 35.66% <ø> (+1.39%) ⬆️
key-wallet-ffi/src/managed_account.rs 54.70% <ø> (-2.71%) ⬇️
key-wallet-ffi/src/managed_wallet.rs 68.38% <100.00%> (-6.02%) ⬇️
key-wallet-ffi/src/wallet.rs 21.26% <100.00%> (-3.52%) ⬇️
key-wallet-ffi/src/wallet_manager.rs 71.10% <100.00%> (-4.45%) ⬇️
key-wallet-manager/src/lib.rs 75.80% <100.00%> (+0.54%) ⬆️
key-wallet-manager/src/process_block.rs 92.48% <100.00%> (-0.08%) ⬇️
... and 7 more

... and 27 files with indirect coverage changes