Add argument 'job_script_epilogue'#677
Merged
guillaumeeb merged 2 commits intodask:mainfrom Apr 18, 2025
Merged
Conversation
This allows user to specify commands that should be run after the worker command has exited. The working is similar to 'job_script_prologue' argument.
Contributor
Author
|
I have not added any new example in the documentation for this (I see there's an entire section dedicated to job_script_prologue). So question to maintainers, do you think it is necessary to give examples for this parameter seperately? |
Member
|
So sorry that we never provided any feedback here, this looks perfect to me. @jacobtomlinson any thought? About the documentation, just a mention of this arg in the doc section you are pointing to would have been great, but I guess you are probably not into this, are you @maneesh29s? |
guillaumeeb
approved these changes
Apr 4, 2025
Contributor
Author
|
No problem, I will update the documentation |
jacobtomlinson
approved these changes
Apr 4, 2025
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Sure this looks great to me!
Contributor
Author
|
@guillaumeeb I have updated the docs as you suggested. |
Member
|
Thanks @maneesh29s ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #639
This allows user to specify commands that should be run after the worker command has exited.
The working is similar to 'job_script_prologue' argument.