Skip to content

Commit b2e1554

Browse files
committed
Remove unrelated CI fixes from PR 9272
1 parent 8a956a1 commit b2e1554

9 files changed

Lines changed: 15 additions & 35 deletions

File tree

distributed/dashboard/tests/test_scheduler_bokeh.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1180,7 +1180,6 @@ async def test_lots_of_tasks(c, s, a, b):
11801180
"distributed.scheduler.dashboard.tls.cert": get_cert("tls-cert.pem"),
11811181
"distributed.scheduler.dashboard.tls.ca-file": get_cert("tls-ca-cert.pem"),
11821182
},
1183-
timeout=60,
11841183
)
11851184
async def test_https_support(c, s, a, b):
11861185
port = s.http_server.port

distributed/diagnostics/progressbar.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,9 +337,8 @@ def __init__(
337337
**kwargs,
338338
):
339339
super().__init__(keys, scheduler, **kwargs)
340-
from ipywidgets import HTML, VBox
340+
from ipywidgets import VBox
341341

342-
self.elapsed_time = HTML("")
343342
self.widget = VBox([])
344343

345344
def make_widget(self, all):

distributed/diagnostics/tests/test_progress_widgets.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,6 @@ def test_values(client):
9191
client.sync(p.listen)
9292
assert p.status == "error"
9393

94-
95-
def test_multi_progressbar_widget_empty_keys_does_not_error():
96-
p = MultiProgressWidget([], scheduler="tcp://127.0.0.1:1")
97-
p._draw_stop(remaining={}, status="finished")
98-
assert "Finished" in p.elapsed_time.value
99-
100-
10194
def test_progressbar_done(client):
10295
L = [client.submit(inc, i) for i in range(5)]
10396
wait(L)

distributed/shuffle/tests/test_shuffle.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from tornado.ioloop import IOLoop
2020

2121
import dask
22+
from dask.dataframe._compat import PANDAS_GE_300
2223
from dask.utils import key_split
2324

2425
from distributed.comm.core import Comm
@@ -2424,6 +2425,7 @@ async def test_handle_null_partitions(c, s, a, b):
24242425
await assert_scheduler_cleanup(s)
24252426

24262427

2428+
@pytest.mark.xfail(PANDAS_GE_300, reason="dask/distributed#9184", strict=True)
24272429
@gen_cluster(client=True)
24282430
async def test_handle_null_partitions_2(c, s, a, b):
24292431
def make_partition(i):

distributed/tests/test_batched.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ async def send():
172172

173173
async def recv():
174174
while True:
175-
result = await wait_for(comm.read(), 5)
175+
result = await wait_for(comm.read(), 1)
176176
L.extend(result)
177177
if result[-1] == 9999:
178178
break

distributed/tests/test_nanny.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,8 +635,7 @@ async def test_failure_during_worker_initialization(s):
635635
with captured_logger(logger="distributed.nanny", level=logging.WARNING) as logs:
636636
with pytest.raises(RuntimeError):
637637
await Nanny(s.address, foo="bar")
638-
assert "Failed to start process" in logs.getvalue()
639-
assert "unexpected keyword argument 'foo'" in logs.getvalue()
638+
assert "Restarting worker" not in logs.getvalue()
640639

641640

642641
@gen_cluster(client=True, Worker=Nanny)

distributed/tests/test_scheduler.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3642,7 +3642,6 @@ def print_memory_info(msg: str) -> None:
36423642
# as fast as on Linux. Note that this behaviour is heavily impacted by OS tweaks,
36433643
# meaning that what you observe on your local host may behave differently on CI.
36443644
if not LINUX:
3645-
await asyncio.gather(*(n.close() for n in nannies))
36463645
return
36473646

36483647
print_memory_info("Before clearing memory leak")
@@ -4030,7 +4029,6 @@ async def test_gather_on_worker_bad_sender(c, s, a, b):
40304029
async def test_gather_on_worker_bad_sender_replicated(c, s, a, b, missing_first):
40314030
"""One of the senders for a key is missing, but the key is available somewhere else"""
40324031
x = await c.scatter("x", workers=[a.address])
4033-
await async_poll_for(lambda: x.key in a.data)
40344032
bad_addr = "tcp://127.0.0.1:12345"
40354033
# Order matters; test both
40364034
addrs = [bad_addr, a.address] if missing_first else [a.address, bad_addr]

distributed/tests/test_stress.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -328,15 +328,12 @@ async def test_chaos_rechunk(c, s, *workers):
328328
y = x.rechunk((10000, 20)).rechunk((20, 10000)).sum()
329329
z = c.compute(y)
330330

331-
try:
332-
start = time()
333-
while time() < start + 10:
334-
if z.status == "error":
335-
await z
336-
if z.status == "finished":
337-
return
338-
await asyncio.sleep(0.1)
339-
340-
await z.cancel()
341-
finally:
342-
await asyncio.gather(*(w.close() for w in workers))
331+
start = time()
332+
while time() < start + 10:
333+
if z.status == "error":
334+
await z
335+
if z.status == "finished":
336+
return
337+
await asyncio.sleep(0.1)
338+
339+
await z.cancel()

distributed/tests/test_worker.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3017,8 +3017,6 @@ async def test_log_remove_worker(c, s, a, b):
30173017
if "stimulus_id" in ev: # Strip timestamp
30183018
ev["stimulus_id"] = ev["stimulus_id"].rsplit("-", 1)[0]
30193019

3020-
worker_get_client_events = events.pop("worker-get-client")
3021-
30223020
assert events == {
30233021
a.address: [
30243022
{
@@ -3093,14 +3091,9 @@ async def test_log_remove_worker(c, s, a, b):
30933091
"worker": b.address,
30943092
},
30953093
],
3094+
"worker-get-client": [{"client": c.id, "timeout": 5, "worker": b.address}],
30963095
}
30973096

3098-
assert {
3099-
"client": c.id,
3100-
"timeout": 5,
3101-
"worker": b.address,
3102-
} in worker_get_client_events
3103-
31043097

31053098
@gen_cluster(client=True)
31063099
async def test_task_flight_compute_oserror(c, s, a, b):

0 commit comments

Comments
 (0)