Log client addresses in scheduler lifecycle messages#9270
Draft
peter941221 wants to merge 5 commits into
Draft
Conversation
Signed-off-by: peter941221 <peter941221@gmail.com>
Signed-off-by: peter941221 <peter941221@gmail.com>
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 30 files - 1 30 suites - 1 10h 21m 28s ⏱️ - 21m 36s For more details on these failures, see this check. Results for commit d42d844. ± Comparison against base commit d8fabe2. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientStateso the same address is available throughout the client lifecycleCloses #8000
Testing
python -m py_compile distributed/scheduler.py distributed/tests/test_scheduler.pypython -m pytest distributed/tests/test_scheduler.py -k client_connection_logs_include_address(local environment is missingdask, so pytest fails during config import)