Skip to content

Fix Color Contrast#644

Merged
pancakereport merged 1 commit intomasterfrom
color-contrast-fix
Jun 2, 2025
Merged

Fix Color Contrast#644
pancakereport merged 1 commit intomasterfrom
color-contrast-fix

Conversation

@pancakereport
Copy link
Copy Markdown
Contributor

@pancakereport pancakereport commented May 30, 2025

per @sean-morris

  • Blue: Background: #EDEDED; Foreground: #002FA7 --> 9.13:1

  • Gold: Background: #EDEDED; Foreground: #706700 --> 4.94:1

  • Wrote test for feature - not a feature; no test necessary

  • Added changes to CHANGELOG.md - did not add to CHANGELOG because this isn't really a "notable" feature imo

per @sean-morris

- Blue: Background: #EDEDED; Foreground: #002FA7 --> 9.13:1
- Gold: Background: #EDEDED; Foreground: #706700 --> 4.94:1
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.976%. remained the same
when pulling 60d8505 on color-contrast-fix
into a71010d on master.

Copy link
Copy Markdown
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pancakereport pancakereport merged commit 43a2f2b into master Jun 2, 2025
2 checks passed
@pancakereport pancakereport deleted the color-contrast-fix branch June 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change colors of charts to match contrast ratio standards

3 participants