Skip to content

Add the angle function#725

Closed
NeilGirdhar wants to merge 1 commit into
data-apis:mainfrom
NeilGirdhar:angle
Closed

Add the angle function#725
NeilGirdhar wants to merge 1 commit into
data-apis:mainfrom
NeilGirdhar:angle

Conversation

@NeilGirdhar

@NeilGirdhar NeilGirdhar commented May 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #714

@lucascolley

Copy link
Copy Markdown
Member

see also gh-718

@NeilGirdhar

Copy link
Copy Markdown
Contributor Author

My mistake, feel free to close 😄

@NeilGirdhar

NeilGirdhar commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Actually, if you look carefully at the other one, there are some errors (doesn't handle integers, doesn't handle non float64 floats properly, etc.)

To my eye, this looks closer to ideal? But feel free to do what you think is best.

@lucascolley

Copy link
Copy Markdown
Member

Would you be willing to review that one?

@NeilGirdhar NeilGirdhar left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(whoops)

@lucascolley

Copy link
Copy Markdown
Member

great thanks for reviewing, let's continue over there

@NeilGirdhar NeilGirdhar deleted the angle branch May 29, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: add angle

2 participants