Tighten tests on iinfo/finfo

Author: crusaderky

array_api_tests/test_data_type_functions.py

@@ -147,9 +147,12 @@ def test_can_cast(_from, to):
         assert out == expected, f"{out=}, but should be {expected} {f_func}"
 
 
-@pytest.mark.parametrize("dtype", dh.real_float_dtypes)
-def test_finfo(dtype):
-    out = xp.finfo(dtype)
+@pytest.mark.parametrize("arg_type", ["dtype", "array"])
+@pytest.mark.parametrize("dtype", dh.real_float_dtypes + dh.complex_dtypes)
+def test_finfo(dtype, arg_type):
+    arg = xp.asarray(1, dtype=dtype) if arg_type == "array" else dtype
+    out = xp.finfo(arg)
+
     f_func = f"[finfo({dh.dtype_to_name[dtype]})]"
     for attr, stype in [
         ("bits", int),
@@ -164,12 +167,30 @@ def test_finfo(dtype):
             value, stype
         ), f"type(out.{attr})={type(value)!r}, but should be {stype.__name__} {f_func}"
     assert hasattr(out, "dtype"), f"out has no attribute 'dtype' {f_func}"
-    # TODO: test values
+
+    assert isinstance(out.bits, int)
+    assert isinstance(out.eps, float)
+    assert isinstance(out.max, float)
+    assert isinstance(out.min, float)
+    assert isinstance(out.smallest_normal, float)
+    if dtype == xp.complex64:
+        assert out.dtype == xp.float32
+    elif dtype == xp.complex128:
+        assert out.dtype == xp.float64
+    else:
+        assert out.dtype == dtype
+    # Guard vs. numpy.dtype.__eq__ lax comparison
+    assert not isinstance(out.dtype, str)
+    assert out.dtype is not float
+    assert out.dtype is not complex
 
 
-@pytest.mark.parametrize("dtype", dh.int_dtypes)
-def test_iinfo(dtype):
-    out = xp.iinfo(dtype)
+@pytest.mark.parametrize("arg_type", ["dtype", "array"])
+@pytest.mark.parametrize("dtype", dh.int_dtypes + dh.uint_dtypes)
+def test_iinfo(dtype, arg_type):
+    arg = xp.asarray(1, dtype=dtype) if arg_type == "array" else dtype
+    out = xp.iinfo(arg)
+
     f_func = f"[iinfo({dh.dtype_to_name[dtype]})]"
     for attr in ["bits", "max", "min"]:
         assert hasattr(out, attr), f"out has no attribute '{attr}' {f_func}"
@@ -178,7 +199,14 @@ def test_iinfo(dtype):
             value, int
         ), f"type(out.{attr})={type(value)!r}, but should be int {f_func}"
     assert hasattr(out, "dtype"), f"out has no attribute 'dtype' {f_func}"
-    # TODO: test values
+
+    assert isinstance(out.bits, int)
+    assert isinstance(out.max, int)
+    assert isinstance(out.min, int)
+    assert out.dtype == dtype
+    # Guard vs. numpy.dtype.__eq__ lax comparison
+    assert not isinstance(out.dtype, str)
+    assert out.dtype is not int
 
 
 def atomic_kinds() -> st.SearchStrategy[Union[DataType, str]]: