Skip to content

Commit 470a35b

Browse files
committed
fix(renderer): do not assign empty validator fields
1 parent c6eb728 commit 470a35b

6 files changed

Lines changed: 10 additions & 70 deletions

File tree

packages/pf3-component-mapper/src/tests/__snapshots__/input-addon.test.js.snap

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ exports[`<Input Addon> should render group button before input addon correctly 1
397397
label="Text Box With Input Addon"
398398
name="text_box_21"
399399
title="Text Box With Input Addon"
400-
validate={[Function]}
401400
>
402401
<Pf3FormGroup
403402
inputAddon={
@@ -540,7 +539,6 @@ exports[`<Input Addon> should render group button before input addon correctly 1
540539
]
541540
}
542541
name="i-a-g-2"
543-
validate={[Function]}
544542
>
545543
<InputGroupButton
546544
bsClass="input-group-btn"
@@ -563,7 +561,6 @@ exports[`<Input Addon> should render group button before input addon correctly 1
563561
label="Set 1"
564562
name="set1"
565563
onClick={[Function]}
566-
validate={[Function]}
567564
>
568565
<Button
569566
active={false}
@@ -601,7 +598,6 @@ exports[`<Input Addon> should render group button before input addon correctly 1
601598
<Button
602599
label="Set 2"
603600
name="set2"
604-
validate={[Function]}
605601
>
606602
<Button
607603
active={false}
@@ -1121,7 +1117,6 @@ exports[`<Input Addon> should render group mixed before input addon correctly 1`
11211117
label="Text Box With Input Addon"
11221118
name="text_box_21"
11231119
title="Text Box With Input Addon"
1124-
validate={[Function]}
11251120
>
11261121
<Pf3FormGroup
11271122
inputAddon={
@@ -1266,7 +1261,6 @@ exports[`<Input Addon> should render group mixed before input addon correctly 1`
12661261
]
12671262
}
12681263
name="i-a-g-2"
1269-
validate={[Function]}
12701264
>
12711265
<InputGroupAddon
12721266
bsClass="input-group-addon"
@@ -1288,7 +1282,6 @@ exports[`<Input Addon> should render group mixed before input addon correctly 1`
12881282
<PlainText
12891283
label="-"
12901284
name="name1"
1291-
validate={[Function]}
12921285
variant="span"
12931286
>
12941287
<span
@@ -1335,7 +1328,6 @@ exports[`<Input Addon> should render group mixed before input addon correctly 1`
13351328
]
13361329
}
13371330
name="i-a-g-3"
1338-
validate={[Function]}
13391331
>
13401332
<InputGroupButton
13411333
bsClass="input-group-btn"
@@ -1356,7 +1348,6 @@ exports[`<Input Addon> should render group mixed before input addon correctly 1`
13561348
<Button
13571349
label="Set 3"
13581350
name="set3"
1359-
validate={[Function]}
13601351
>
13611352
<Button
13621353
active={false}
@@ -1723,7 +1714,6 @@ exports[`<Input Addon> should render single after input addon correctly 1`] = `
17231714
label="Text Box With Input Addon"
17241715
name="text_box_21"
17251716
title="Text Box With Input Addon"
1726-
validate={[Function]}
17271717
>
17281718
<Pf3FormGroup
17291719
inputAddon={
@@ -1837,7 +1827,6 @@ exports[`<Input Addon> should render single after input addon correctly 1`] = `
18371827
<PlainText
18381828
label="-"
18391829
name="name1"
1840-
validate={[Function]}
18411830
variant="span"
18421831
>
18431832
<span
@@ -2167,7 +2156,6 @@ exports[`<Input Addon> should render single before input addon correctly 1`] = `
21672156
label="Text Box With Input Addon"
21682157
name="text_box_21"
21692158
title="Text Box With Input Addon"
2170-
validate={[Function]}
21712159
>
21722160
<Pf3FormGroup
21732161
inputAddon={
@@ -2261,7 +2249,6 @@ exports[`<Input Addon> should render single before input addon correctly 1`] = `
22612249
<PlainText
22622250
label="-"
22632251
name="name1"
2264-
validate={[Function]}
22652252
variant="span"
22662253
>
22672254
<span
@@ -2602,7 +2589,6 @@ exports[`<Input Addon> should render single button after input addon correctly 1
26022589
label="Text Box With Input Addon"
26032590
name="text_box_21"
26042591
title="Text Box With Input Addon"
2605-
validate={[Function]}
26062592
>
26072593
<Pf3FormGroup
26082594
inputAddon={
@@ -2713,7 +2699,6 @@ exports[`<Input Addon> should render single button after input addon correctly 1
27132699
<Button
27142700
label="Set 3"
27152701
name="set3"
2716-
validate={[Function]}
27172702
>
27182703
<Button
27192704
active={false}
@@ -3099,7 +3084,6 @@ exports[`<Input Addon> should render single button before input addon correctly
30993084
label="Text Box With Input Addon"
31003085
name="text_box_21"
31013086
title="Text Box With Input Addon"
3102-
validate={[Function]}
31033087
>
31043088
<Pf3FormGroup
31053089
inputAddon={
@@ -3218,7 +3202,6 @@ exports[`<Input Addon> should render single button before input addon correctly
32183202
]
32193203
}
32203204
name="i-a-g-2"
3221-
validate={[Function]}
32223205
>
32233206
<InputGroupButton
32243207
bsClass="input-group-btn"
@@ -3239,7 +3222,6 @@ exports[`<Input Addon> should render single button before input addon correctly
32393222
<Button
32403223
label="Set 2"
32413224
name="set2"
3242-
validate={[Function]}
32433225
>
32443226
<Button
32453227
active={false}
@@ -3948,7 +3930,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
39483930
label="Text Box With Input Addon"
39493931
name="text_box_21"
39503932
title="Text Box With Input Addon"
3951-
validate={[Function]}
39523933
>
39533934
<Pf3FormGroup
39543935
inputAddon={
@@ -4145,7 +4126,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
41454126
]
41464127
}
41474128
name="i-a-g-2"
4148-
validate={[Function]}
41494129
>
41504130
<InputGroupButton
41514131
bsClass="input-group-btn"
@@ -4168,7 +4148,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
41684148
label="Set 1"
41694149
name="set1"
41704150
onClick={[Function]}
4171-
validate={[Function]}
41724151
>
41734152
<Button
41744153
active={false}
@@ -4206,7 +4185,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
42064185
<Button
42074186
label="Set 2"
42084187
name="set2"
4209-
validate={[Function]}
42104188
>
42114189
<Button
42124190
active={false}
@@ -4286,7 +4264,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
42864264
]
42874265
}
42884266
name="i-a-g-2"
4289-
validate={[Function]}
42904267
>
42914268
<InputGroupAddon
42924269
bsClass="input-group-addon"
@@ -4308,7 +4285,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
43084285
<PlainText
43094286
label="-"
43104287
name="name1"
4311-
validate={[Function]}
43124288
variant="span"
43134289
>
43144290
<span
@@ -4355,7 +4331,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
43554331
]
43564332
}
43574333
name="i-a-g-3"
4358-
validate={[Function]}
43594334
>
43604335
<InputGroupButton
43614336
bsClass="input-group-btn"
@@ -4376,7 +4351,6 @@ exports[`<Input Addon> should render the ultimate input addon correctly 1`] = `
43764351
<Button
43774352
label="Set 3"
43784353
name="set3"
4379-
validate={[Function]}
43804354
>
43814355
<Button
43824356
active={false}

packages/pf3-component-mapper/src/tests/__snapshots__/wizard.test.js.snap

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ exports[`<Wizard /> should render Wizard correctly 1`] = `
289289
]
290290
}
291291
name="Wizard"
292-
validate={[Function]}
293292
>
294293
<Wizard
295294
Wizard={[Function]}
@@ -309,7 +308,6 @@ exports[`<Wizard /> should render Wizard correctly 1`] = `
309308
]
310309
}
311310
name="Wizard"
312-
validate={[Function]}
313311
>
314312
<WizardInternal
315313
activeStepIndex={0}
@@ -389,7 +387,6 @@ exports[`<Wizard /> should render Wizard correctly 1`] = `
389387
onKeyDown={[Function]}
390388
prevSteps={Array []}
391389
setPrevSteps={[Function]}
392-
validate={[Function]}
393390
>
394391
<div
395392
onKeyDown={[Function]}
@@ -1083,7 +1080,6 @@ exports[`<Wizard /> should render Wizard with conditional steps correctly 1`] =
10831080
]
10841081
}
10851082
name="Wizard"
1086-
validate={[Function]}
10871083
>
10881084
<Wizard
10891085
Wizard={[Function]}
@@ -1108,7 +1104,6 @@ exports[`<Wizard /> should render Wizard with conditional steps correctly 1`] =
11081104
]
11091105
}
11101106
name="Wizard"
1111-
validate={[Function]}
11121107
>
11131108
<WizardInternal
11141109
activeStepIndex={0}
@@ -1187,7 +1182,6 @@ exports[`<Wizard /> should render Wizard with conditional steps correctly 1`] =
11871182
onKeyDown={[Function]}
11881183
prevSteps={Array []}
11891184
setPrevSteps={[Function]}
1190-
validate={[Function]}
11911185
>
11921186
<div
11931187
onKeyDown={[Function]}
@@ -1989,7 +1983,6 @@ exports[`<Wizard /> should render Wizard with stepsInfo correctly 1`] = `
19891983
},
19901984
]
19911985
}
1992-
validate={[Function]}
19931986
>
19941987
<Wizard
19951988
Wizard={[Function]}
@@ -2019,7 +2012,6 @@ exports[`<Wizard /> should render Wizard with stepsInfo correctly 1`] = `
20192012
},
20202013
]
20212014
}
2022-
validate={[Function]}
20232015
>
20242016
<WizardInternal
20252017
activeStepIndex={0}
@@ -2109,7 +2101,6 @@ exports[`<Wizard /> should render Wizard with stepsInfo correctly 1`] = `
21092101
},
21102102
]
21112103
}
2112-
validate={[Function]}
21132104
>
21142105
<div
21152106
onKeyDown={[Function]}
@@ -2861,7 +2852,6 @@ exports[`<Wizard /> should render Wizard with title correctly 1`] = `
28612852
}
28622853
name="Wizard"
28632854
title="Wizard title"
2864-
validate={[Function]}
28652855
>
28662856
<Wizard
28672857
Wizard={[Function]}
@@ -2882,7 +2872,6 @@ exports[`<Wizard /> should render Wizard with title correctly 1`] = `
28822872
}
28832873
name="Wizard"
28842874
title="Wizard title"
2885-
validate={[Function]}
28862875
>
28872876
<WizardInternal
28882877
activeStepIndex={0}
@@ -2963,7 +2952,6 @@ exports[`<Wizard /> should render Wizard with title correctly 1`] = `
29632952
prevSteps={Array []}
29642953
setPrevSteps={[Function]}
29652954
title="Wizard title"
2966-
validate={[Function]}
29672955
>
29682956
<div
29692957
onKeyDown={[Function]}

0 commit comments

Comments
 (0)