Merge pull request #1323 from jspannu919/float_issue_fix

Float Issue fix

Author: Hyperkid123

packages/react-form-renderer/src/tests/form-renderer/data-types.test.js

@@ -92,6 +92,14 @@ describe('data types', () => {
       it('converts a negative integer', () => {
         expect(convertType(dataTypes.INTEGER, '-12132')).toEqual(-12132);
       });
+
+      it('converts a floating number with nothing preceding decimal', () => {
+        expect(convertType(dataTypes.FLOAT, '123.')).toEqual('123.');
+      });
+
+      it('converts a floating number', () => {
+        expect(convertType(dataTypes.FLOAT, '123.0')).toEqual(123.0);
+      });
     });
   });
 });

packages/react-form-renderer/src/use-field-api/convert-type.js

@@ -18,6 +18,18 @@ const castToBoolean = (value) => {
  */
 const canBeConvertedToNumber = (value) => !isNaN(Number(value)) && value !== '';
 
+/**
+ * Check if the value can be converted to float
+ * @param {Any} value value to be checked
+ */
+const canBeConvertedToFloat = (value) => {
+  if (typeof value == 'string' && value.endsWith('.')) {
+    return false;
+  }
+
+  return canBeConvertedToNumber(value);
+};
+
 /**
  * Changes the value type
  * @param {FieldDataTypes} dataType type for value conversion
@@ -28,7 +40,7 @@ const convertType = (dataType, value) => {
     case dataTypes.INTEGER:
       return canBeConvertedToNumber(value) ? parseInt(value) : value;
     case dataTypes.FLOAT:
-      return canBeConvertedToNumber(value) ? parseFloat(value) : value;
+      return canBeConvertedToFloat(value) ? parseFloat(value) : value;
     case dataTypes.NUMBER:
       return canBeConvertedToNumber(value) ? Number(value) : value;
     case dataTypes.BOOLEAN: