Skip to content

Commit 43cd482

Browse files
author
Roelant Vos
committed
Renamed some array/list items to be plural, conforming coding conventions.
1 parent 3435365 commit 43cd482

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

ClassLibrary/DataWarehouseAutomation/DataWarehouseAutomation/DataObjectMapping.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ public class DataObjectMapping
1818
/// <summary>
1919
/// Free-form and optional classification for the mapping for use in ETL generation logic (evaluation).
2020
/// </summary>
21-
[JsonProperty("mappingClassification")]
22-
public List<Classification> mappingClassification { get; set; }
21+
[JsonProperty("mappingClassifications")]
22+
public List<Classification> mappingClassifications { get; set; }
2323

2424
/// <summary>
2525
/// The source object of the mapping.
2626
/// </summary>
27-
[JsonProperty("sourceDataObject")]
28-
public DataObject sourceDataObject { get; set; }
27+
[JsonProperty("sourceDataObjects")]
28+
public List<DataObject> sourceDataObjects { get; set; }
2929

3030
/// <summary>
3131
/// The target object of the mapping.
@@ -37,20 +37,20 @@ public class DataObjectMapping
3737
/// Optional associated data object (collection) for purposes other than source- and target relationship.
3838
/// For example Lookups, merge joins etc.
3939
/// </summary>
40-
[JsonProperty("relatedDataObject")]
41-
public List<DataObject> relatedDataObject { get; set; }
40+
[JsonProperty("relatedDataObjects")]
41+
public List<DataObject> relatedDataObjects { get; set; }
4242

4343
/// <summary>
4444
/// The collection of individual attribute (column) mappings.
4545
/// </summary>
46-
[JsonProperty("dataItemMapping", NullValueHandling = NullValueHandling.Ignore)]
47-
public List<DataItemMapping> dataItemMapping { get; set; }
46+
[JsonProperty("dataItemMappings", NullValueHandling = NullValueHandling.Ignore)]
47+
public List<DataItemMapping> dataItemMappings { get; set; }
4848

4949
/// <summary>
5050
/// The definition of the Business Key for the source-to-target mapping.
5151
/// </summary>
52-
[JsonProperty("businessKey")]
53-
public List<BusinessKey> businessKey { get; set; }
52+
[JsonProperty("businessKeys")]
53+
public List<BusinessKey> businessKeys { get; set; }
5454

5555
/// <summary>
5656
/// Any filtering that needs to be applied to the source-to-target mapping.

Examples/DV_Handlebars/TemplateSampleBasicWithExtensions.Handlebars

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
Working on {{mappingName}}.
44

5-
Data Object {{targetDataObject.name}} first extension is that the {{targetDataObject.extensions.0.key}} is {{targetDataObject.extensions.0.value}}
5+
Data Object {{targetDataObject.name}}'s first extension is that the {{targetDataObject.extensions.0.key}} is {{targetDataObject.extensions.0.value}}.
66

7-
In addition to this, the {{targetDataObject.extensions.1.key}} is {{targetDataObject.extensions.1.value}}
7+
In addition to this, the {{targetDataObject.extensions.1.key}} is {{targetDataObject.extensions.1.value}}.
88

99
{{/each}}
1010

GenericInterface/interfaceDataWarehouseAutomationMetadata.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
"description": "Unique name which identifies the mapping.",
3939
"type": [ "string", "null" ]
4040
},
41-
"mappingClassification": {
42-
"$id": "#/definitions/dataObjectMapping/properties/dataObjectMappingClassification",
41+
"mappingClassifications": {
42+
"$id": "#/definitions/dataObjectMapping/properties/dataObjectMappingClassifications",
4343
"description": "Classification for the source-to-target mapping (free form).",
4444
"type": [ "array", "null" ],
4545
"items": {
@@ -48,8 +48,8 @@
4848
"minItems": 0,
4949
"uniqueItems": true
5050
},
51-
"sourceDataObject": {
52-
"$id": "#/definitions/dataObjectMapping/properties/sourceDataObject",
51+
"sourceDataObjects": {
52+
"$id": "#/definitions/dataObjectMapping/properties/sourceDataObjects",
5353
"description": "The source object of the mapping. This can either be an object or a query.",
5454
"oneOf": [
5555
{
@@ -71,24 +71,24 @@
7171
"description": "The target object of the mapping.",
7272
"$ref": "#/definitions/dataObject"
7373
},
74-
"relatedDataObject": {
75-
"$id": "#/definitions/dataObjectMapping/properties/relatedDataObject",
74+
"relatedDataObjects": {
75+
"$id": "#/definitions/dataObjectMapping/properties/relatedDataObjects",
7676
"description": "The collection of data objects with a different relationship than either source or target e.g. lookup.",
7777
"type": [ "array", "null" ],
7878
"items": {
7979
"$ref": "#/definitions/dataObject"
8080
}
8181
},
82-
"dataItemMapping": {
83-
"$id": "#/definitions/dataObjectMapping/properties/dataItemMapping",
82+
"dataItemMappings": {
83+
"$id": "#/definitions/dataObjectMapping/properties/dataItemMappings",
8484
"description": "The collection of column-to-column mappings.",
8585
"type": [ "array", "null" ],
8686
"items": {
8787
"$ref": "#/definitions/dataItemMapping"
8888
}
8989
},
90-
"businessKey": {
91-
"$id": "#/definitions/dataObjectMapping/properties/businessKey",
90+
"businessKeys": {
91+
"$id": "#/definitions/dataObjectMapping/properties/businessKeys",
9292
"description": "The Business Key definition for the mapping.",
9393
"type": [ "array", "null" ],
9494
"items": {

0 commit comments

Comments
 (0)