Skip to content

phaseplot widget, export layers to yt ds#152

Open
chrishavlin wants to merge 16 commits into
data-exp-lab:mainfrom
chrishavlin:phaseplot_widget
Open

phaseplot widget, export layers to yt ds#152
chrishavlin wants to merge 16 commits into
data-exp-lab:mainfrom
chrishavlin:phaseplot_widget

Conversation

@chrishavlin
Copy link
Copy Markdown
Collaborator

This PR adds:

  • a convenience function for exporting layers loaded in napari to a uniform grid yt ds
  • a new phaseplot widget

may split those to separate prs...

@chrishavlin chrishavlin added the enhancement New feature or request label Nov 21, 2024
@chrishavlin chrishavlin marked this pull request as draft November 21, 2024 18:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2024

Codecov Report

❌ Patch coverage is 99.19137% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.55%. Comparing base (eb16ab0) to head (d27faa7).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
src/yt_napari/_widget_2d_plots.py 98.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   99.60%   99.55%   -0.05%     
==========================================
  Files          37       40       +3     
  Lines        2799     3170     +371     
==========================================
+ Hits         2788     3156     +368     
- Misses         11       14       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrishavlin
Copy link
Copy Markdown
Collaborator Author

chrishavlin commented Nov 21, 2024

Still needs a bunch of UI design and fixes:

  • labels (those drop downs are the PhasePlot x, y, z and weight field arguments
  • add options for the rest of the PhasePlot arguments
  • add some options for plot callbacks (log switches, colormap, etc)
  • the matplotlib figure does not rescale well with the window

but there's a figure!

Screenshot from 2024-11-21 14-43-44

@chrishavlin
Copy link
Copy Markdown
Collaborator Author

pre-commit.ci autofix

@chrishavlin
Copy link
Copy Markdown
Collaborator Author

latest push adds some callbacks, but at present it needs to fully re-render

Screenshot from 2025-02-26 15-08-19

@chrishavlin chrishavlin changed the title WIP: phaseplot widget, export layers to yt ds phaseplot widget, export layers to yt ds Feb 28, 2025
@chrishavlin chrishavlin marked this pull request as ready for review February 28, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant