Skip to content

Commit c1e11ab

Browse files
harishhk107vikasrathee-cs
authored andcommitted
fix: remove error stack trace from validation failures
1 parent 87809d1 commit c1e11ab

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

src/main/java/io/cdap/plugin/salesforce/SalesforceConnectionUtil.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,7 @@ public static OAuthInfo getOAuthInfo(SalesforceConnectorInfo config, FailureColl
130130
} catch (Exception e) {
131131
String message = getSalesforceErrorMessageFromException(e);
132132
collector.addFailure("Error encountered while establishing connection: " + message,
133-
"Please verify authentication properties are provided correctly")
134-
.withStacktrace(e.getStackTrace());
133+
"Please verify authentication properties are provided correctly");
135134
throw collector.getOrThrowException();
136135
}
137136
return oAuthInfo;

src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceSourceConfig.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ public void validate(FailureCollector collector, @Nullable OAuthInfo oAuthInfo)
185185
queryDescriptor = SalesforceQueryParser.getObjectDescriptorFromQuery(query);
186186
} catch (SOQLParsingException e) {
187187
collector.addFailure(String.format("Invalid SOQL query '%s' : %s", query, e.getMessage()), null)
188-
.withStacktrace(e.getStackTrace())
189188
.withConfigProperty(SalesforceSourceConstants.PROPERTY_QUERY);
190189
throw collector.getOrThrowException();
191190
}
@@ -255,8 +254,7 @@ private void validateCompoundFields(String sObjectName, List<String> fieldNames,
255254
String errorMessage = SalesforceConnectionUtil.getSalesforceErrorMessageFromException(e);
256255
collector.addFailure(
257256
String.format("Cannot establish connection to Salesforce to describe SObject: '%s' with error %s",
258-
sObjectName, errorMessage), null)
259-
.withStacktrace(e.getStackTrace());
257+
sObjectName, errorMessage), null);
260258
}
261259
}
262260

@@ -353,7 +351,7 @@ private boolean isCustomObject(String sObjectName, FailureCollector collector, O
353351
} catch (ConnectionException e) {
354352
String message = SalesforceConnectionUtil.getSalesforceErrorMessageFromException(e);
355353
collector.addFailure(String.format("There was issue communicating with Salesforce due to error: %s", message),
356-
null).withStacktrace(e.getStackTrace());
354+
null);
357355
throw collector.getOrThrowException();
358356
}
359357
}

0 commit comments

Comments
 (0)