Added some more exception handling

Author: Roelant Vos

Virtual_EDW/CustomTabPage.cs

@@ -581,12 +581,12 @@ private void GenerateFromPattern()
                 for (int x = 0; x <= _localCheckedListBox.CheckedItems.Count - 1; x++)
                 {
                     var targetTableName = _localCheckedListBox.CheckedItems[x].ToString();
-                    RaiseOnChangeMainText(@"Processing generation for " + targetTableName + ".\r\n");
+                    RaiseOnChangeMainText(@"Generating code for " + targetTableName + ".\r\n");
 
-                    // Only process the selected items in the total of available source-to-target mappings
+                    // Only process the selected items in the total of available source-to-target mappings.
                     ItemList.TryGetValue(targetTableName, out var dataObjectMappingList);
 
-                    // Return the result to the user
+                    // Return the result to the user.
                     try
                     {
                         // Compile the template, and merge it with the metadata.
@@ -601,9 +601,9 @@ private void GenerateFromPattern()
                                 var json = JsonConvert.SerializeObject(dataObjectMappingList, Formatting.Indented);
                                 localRichTextBoxGenerationOutput.AppendText(json + "\r\n\r\n");
                             }
-                            catch (Exception ex)
+                            catch (Exception exception)
                             {
-                                RaiseOnChangeMainText("An error was encountered while generating the Json metadata. The error message is: " + ex);
+                                RaiseOnChangeMainText("An error was encountered while parsing the Json metadata. The error message is: " + exception.Message);
                             }
                         }
 
@@ -622,7 +622,7 @@ private void GenerateFromPattern()
                         //Generate in database.
                         if (GenerateInDatabaseFlag)
                         {
-                            // Find the right connection for the pattern connection key
+                            // Find the right connection for the pattern connection key.
                             var localConnection = TeamConfiguration.GetTeamConnectionByInternalId(localLabelActiveConnectionKeyValue.Text, FormBase.TeamConfigurationSettings.ConnectionDictionary);
 
                             if (localConnection != null)
@@ -635,7 +635,9 @@ private void GenerateFromPattern()
                                 }
                                 catch
                                 {
-                                    FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, $"There was an issue creating the schema {FormBase.VdwConfigurationSettings.VdwSchema} in database {conn.Database}."));
+                                    var errorMessage = $"There was an issue creating the schema '{FormBase.VdwConfigurationSettings.VdwSchema}' in database '{conn.Database}'.";
+                                    RaiseOnChangeMainText(errorMessage);
+                                    FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, errorMessage));
                                 }
 
                                 try
@@ -644,19 +646,24 @@ private void GenerateFromPattern()
                                 }
                                 catch
                                 {
-                                    FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, $"There was an issue executing the query {result} in database {conn.Database}."));
+                                    var errorMessage = $"There was an issue executing the query '{result}' in database '{conn.Database}'.";
+                                    RaiseOnChangeMainText(errorMessage);
+                                    FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, errorMessage));
                                 }
                             }
                             else
                             {
-                                FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, $"There was an issue establishing a connection to generate the output for {targetTableName}. Is there a TEAM connections file in the configuration directory?"));
+                                var errorMessage = $"There was an issue establishing a connection to generate the output for '{targetTableName}'. Is there a TEAM connections file in the configuration directory?";
+                                RaiseOnChangeMainText(errorMessage);
+                                FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, errorMessage));
                             }
                         }
-
                     }
-                    catch (Exception ex)
+                    catch (Exception exception)
                     {
-                        FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, $"The template could not be compiled. The error message is: {ex.Message}"));
+                        var errorMessage = $"The template could not be compiled. The error message is: {exception.Message}";
+                        RaiseOnChangeMainText(errorMessage);
+                        FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, errorMessage));
                     }
                 }
             }

Virtual_EDW/VdwUtility.cs

@@ -201,7 +201,7 @@ public static void CreateVdwSchema(SqlConnection connection)
 
                 // Execute the check to see if the schema exists or not
                 var checkCommand = new SqlCommand($"SELECT CASE WHEN EXISTS (SELECT * FROM sys.schemas WHERE name = '{FormBase.VdwConfigurationSettings.VdwSchema}') THEN 1 ELSE 0 END", connection);
-                var exists = (int) checkCommand.ExecuteScalar() == 1;
+                var exists = (int)checkCommand.ExecuteScalar() == 1;
 
                 if (exists == false)
                 {
@@ -218,7 +218,6 @@ public static void CreateVdwSchema(SqlConnection connection)
                     //createStatement.AppendLine("END");
 
                     createStatement.AppendLine("IF SCHEMA_ID('" + FormBase.VdwConfigurationSettings.VdwSchema + "') IS NULL EXEC('CREATE SCHEMA " + FormBase.VdwConfigurationSettings.VdwSchema + "')");
-                    
 
                     var commandVersion = new SqlCommand(createStatement.ToString(), connection);
 
@@ -227,9 +226,15 @@ public static void CreateVdwSchema(SqlConnection connection)
                     FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Information, $"The VDW schema '{FormBase.VdwConfigurationSettings.VdwSchema}' was created for database '{connection.Database}'."));
                 }
             }
-            catch (Exception ex)
+            catch (Exception exception)
+            {
+                var errorMessage = $"An issue occurred creating the VDW schema '{FormBase.VdwConfigurationSettings.VdwSchema}' in the '{connection.Database}' database. The reported error is {exception.Message}";
+                FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, errorMessage));
+            }
+            finally
             {
-                FormBase.VdwConfigurationSettings.VdwEventLog.Add(Event.CreateNewEvent(EventTypes.Error, $"An issue occurred creating the VDW schema '{FormBase.VdwConfigurationSettings.VdwSchema}'. The reported error is {ex}"));
+                connection.Close();
+                connection.Dispose();
             }
         }