feat: add multi-select filters with URL synchronization and update tests#104
Open
Utkarsha155 wants to merge 2 commits into
Open
feat: add multi-select filters with URL synchronization and update tests#104Utkarsha155 wants to merge 2 commits into
Utkarsha155 wants to merge 2 commits into
Conversation
✅ Deploy Preview for dueventboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
@Utkarsha155 , i am not really sure if this feature is important, also could you rebase your branch!? |
c6e01ee to
5497c9a
Compare
d906cb5 to
60a9fc2
Compare
Author
Hi @yuvimittal , Thanks for the review. I have rebased the branch with the latest main and resolved all issues. All checks are now passing. Please let me know if you’d like any changes or refinements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
This PR introduces multi-select filtering for region and category, enhancing the flexibility of event discovery.
Previously, users could only select a single region or category at a time. This update allows selecting multiple options simultaneously while maintaining URL synchronization, enabling persistence across refresh and shareable filtered links.
Solves issue: #103
How to test these changes
Run:
Open browser at:
Try selecting multiple regions and categories from dropdown
Verify:
?region=India,US)Run tests:
Ensure all tests pass successfully
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Additional information
Key Changes:
useUrlStateto support array values (comma-separated)Benefits:
Screenshots:
Reviewer's checklist