Skip to content

feat: add multi-select filters with URL synchronization and update tests#104

Open
Utkarsha155 wants to merge 2 commits into
data-umbrella:mainfrom
Utkarsha155:multi-select-filters
Open

feat: add multi-select filters with URL synchronization and update tests#104
Utkarsha155 wants to merge 2 commits into
data-umbrella:mainfrom
Utkarsha155:multi-select-filters

Conversation

@Utkarsha155
Copy link
Copy Markdown

Pull Request description

This PR introduces multi-select filtering for region and category, enhancing the flexibility of event discovery.

Previously, users could only select a single region or category at a time. This update allows selecting multiple options simultaneously while maintaining URL synchronization, enabling persistence across refresh and shareable filtered links.

Solves issue: #103


How to test these changes

  • Run:

    npm install
    npm run dev
    
  • Open browser at:

    http://localhost:5173/du-event-board/
    
  • Try selecting multiple regions and categories from dropdown

  • Verify:

    • Multiple selections are applied correctly
    • URL updates (e.g., ?region=India,US)
    • Refresh retains selected filters
  • Run tests:

    npm test
    
  • Ensure all tests pass successfully


Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • New and old tests passed locally.

Additional information

Key Changes:

  • Added multi-select dropdown UI using checkboxes
  • Extended useUrlState to support array values (comma-separated)
  • Updated filtering logic to handle multiple selections
  • Updated test cases to align with new UI behavior

Benefits:

  • Improved user experience with flexible filtering
  • Persistent filters via URL
  • Shareable filtered views

Screenshots:

Screenshot 2026-03-28 222637

Reviewer's checklist

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 28, 2026

Deploy Preview for dueventboard ready!

Name Link
🔨 Latest commit 16a68c0
🔍 Latest deploy log https://app.netlify.com/projects/dueventboard/deploys/69d787d5201cf900087a5370
😎 Deploy Preview https://deploy-preview-104--dueventboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yuvimittal
Copy link
Copy Markdown
Contributor

@Utkarsha155 , i am not really sure if this feature is important, also could you rebase your branch!?

@Utkarsha155 Utkarsha155 force-pushed the multi-select-filters branch 2 times, most recently from c6e01ee to 5497c9a Compare April 9, 2026 10:29
@Utkarsha155 Utkarsha155 force-pushed the multi-select-filters branch from d906cb5 to 60a9fc2 Compare April 9, 2026 10:58
@Utkarsha155
Copy link
Copy Markdown
Author

@Utkarsha155 , i am not really sure if this feature is important, also could you rebase your branch!?

Hi @yuvimittal ,

Thanks for the review.

I have rebased the branch with the latest main and resolved all issues. All checks are now passing.

Please let me know if you’d like any changes or refinements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants