Skip to content

fix: replace sun and moon icons to correct uneven spacing in theme toggle#137

Open
MAY55A wants to merge 1 commit into
data-umbrella:mainfrom
MAY55A:UI-changes
Open

fix: replace sun and moon icons to correct uneven spacing in theme toggle#137
MAY55A wants to merge 1 commit into
data-umbrella:mainfrom
MAY55A:UI-changes

Conversation

@MAY55A
Copy link
Copy Markdown

@MAY55A MAY55A commented Mar 30, 2026

Pull Request description

This pull request fixes uneven spacing due to using text icons for the theme toggle instead of an svg or icon element.
Icons from lucide-react library have been used to correct this.

fixes #136

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

  • Before:
Screenshot 2026-03-30 204201 Screenshot 2026-03-30 204135
  • After:
Screenshot 2026-03-30 203910 Screenshot 2026-03-30 203859

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 30, 2026

Deploy Preview for dueventboard ready!

Name Link
🔨 Latest commit ff0026e
🔍 Latest deploy log https://app.netlify.com/projects/dueventboard/deploys/69d2b2979df29f0008db1976
😎 Deploy Preview https://deploy-preview-137--dueventboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yuvimittal
Copy link
Copy Markdown
Contributor

@MAY55A , please rebase your branch

@MAY55A
Copy link
Copy Markdown
Author

MAY55A commented Apr 5, 2026

Hi @yuvimittal , I updated the branch, you can check it out.

@sanvishukla
Copy link
Copy Markdown
Contributor

@yuvimittal, please merge this, it looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Theme toggle icon not fully centered

3 participants