fix: replace sun and moon icons to correct uneven spacing in theme toggle#137
Open
MAY55A wants to merge 1 commit into
Open
fix: replace sun and moon icons to correct uneven spacing in theme toggle#137MAY55A wants to merge 1 commit into
MAY55A wants to merge 1 commit into
Conversation
✅ Deploy Preview for dueventboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
@MAY55A , please rebase your branch |
Author
|
Hi @yuvimittal , I updated the branch, you can check it out. |
Contributor
|
@yuvimittal, please merge this, it looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
This pull request fixes uneven spacing due to using text icons for the theme toggle instead of an svg or icon element.
Icons from
lucide-reactlibrary have been used to correct this.fixes #136
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: