feat: validate optional event coordinates and improve map fallback behavior#74
Open
Shivampal157 wants to merge 3 commits into
Open
feat: validate optional event coordinates and improve map fallback behavior#74Shivampal157 wants to merge 3 commits into
Shivampal157 wants to merge 3 commits into
Conversation
✅ Deploy Preview for dueventboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Hi @yuvimittal @xmnlab , could you review the PR when you have a moment? I’m happy to adjust anything you’d like changed. |
Contributor
|
@Shivampal157 , please add screenrecording of the working functionality |
Add lat/lng pair and range validation in event generation, preserve backward compatibility for events without coordinates, and update map rendering to ignore invalid coordinates safely. Include coordinate validation unit tests and documentation updates. Closes data-umbrella#73 Made-with: Cursor
Made-with: Cursor
Shivampal157
force-pushed
the
feat/map-coordinates-validation-73
branch
from
9a1ef94 to
dfeab55
Compare
Author
|
@yuvimittal Thanks for the feedback. I’ve rebased this branch on latest upstream Screen recording (working functionality): 6f0276ac-c174-4c76-84ac-225f2f25fbfb.1.mp4Please re-review when you get a chance. |
Author
|
@yuvimittal ,plz review.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented issue #73 to make map mode more reliable without breaking existing event entries.
What changed
Why
Map view existed, but behavior was inconsistent when coordinates were partial/invalid. This makes map behavior predictable for users and safer for maintainers adding data.
How to test
Closes #73