fix(map): resolve triple .find() redundancy and support dynamic themes#90
Closed
Ayush-delta wants to merge 1 commit into
Closed
fix(map): resolve triple .find() redundancy and support dynamic themes#90Ayush-delta wants to merge 1 commit into
Ayush-delta wants to merge 1 commit into
Conversation
✅ Deploy Preview for dueventboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@yuvimittal , I’ve opened this PR resolve triple .find() redundancy and support dynamic themes. Would appreciate it if you could take a look when you have time. Thanks! |
Contributor
|
@Ayush-delta, Hi I have already worked on correcting the theme in the map view in PR #63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
How to test these changes
• * run
$ npm run dev• open the web browser to http://localhost:5173/du-event-board/
• Toggle the light/dark mode icon switcher at the top of the header. The map tile layer should instantly switch base patterns from dark to light.
• Select the "Map" layout, then click on any localized event on the map during "light" mode. It will correctly yield inverted pop-up information boxes instead of static dark overlays.
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information

Here is a view of the newly synchronized Light Theme map tiles rendering properly, with unified CSS variables enforcing crisp readability against the Popup nodes: