Skip to content

feat: remove useless try-finally, etc.#336

Merged
hantmac merged 4 commits into
databendlabs:mainfrom
wayne-pq:feat/optimized-code-wayne
Aug 4, 2025
Merged

feat: remove useless try-finally, etc.#336
hantmac merged 4 commits into
databendlabs:mainfrom
wayne-pq:feat/optimized-code-wayne

Conversation

@wayne-pq
Copy link
Copy Markdown
Contributor

1.remove useless try-finally
2.Do not use end-of-line comments.
3.add DatabendConstant
4.parameters should name ignore or ignored when catch block is null (from Qodana)

2.Do not use end-of-line comments.
3.add DatabendConstant
4.parameters should name ignore or ignored when catch block is null (from Qodana)

Signed-off-by: wayne <oak.wayne@qq.com>
@wayne-pq
Copy link
Copy Markdown
Contributor Author

Code Quality Check return Error: HttpError: Resource not accessible by integration

@hantmac
Copy link
Copy Markdown
Member

hantmac commented Jul 29, 2025

Code Quality Check return Error: HttpError: Resource not accessible by integration

@wayne-pq plz rebase code and re-triger the CI

@wayne-pq
Copy link
Copy Markdown
Contributor Author

Code Quality Check return Error: HttpError: Resource not accessible by integration

@wayne-pq plz rebase code and re-triger the CI

the problem is still exists @hantmac

Copy link
Copy Markdown
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM

@hantmac hantmac merged commit 6965d84 into databendlabs:main Aug 4, 2025
2 of 3 checks passed
@hantmac hantmac mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants