chore: update tonic requirement from 0.13 to 0.14#143
Conversation
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ff3cf6080
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tokio-stream = { version = "0.1.11", features = ["net"] } | ||
| toml = "0.8" | ||
| tonic = { version = "0.13", features = ["transport", "codegen", "tls-native-roots"] } | ||
| tonic = { version = "0.14", features = ["transport", "codegen", "tls-native-roots"] } |
There was a problem hiding this comment.
Updating only tonic to 0.14 leaves crates/common/proto/build.rs using tonic-build 0.13 and prost 0.13. That generator emits client/server stubs with tonic::codec::ProstCodec, but in tonic 0.14 the prost codec/codegen path moved out to the tonic-prost/tonic-prost-build stack, so any crate that includes these generated protos will fail to compile. Please either keep tonic at 0.13 or upgrade the prost/tonic-build/reflection dependencies and build script together.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-0.14
branch
2 times, most recently
from
65bb2b8 to
dd71a3a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd71a3ac0f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tokio-stream = { version = "0.1.11", features = ["net"] } | ||
| toml = "0.8" | ||
| tonic = { version = "0.13", features = ["transport", "codegen", "tls-native-roots"] } | ||
| tonic = { version = "0.14", features = ["transport", "codegen", "tls-native-roots"] } |
There was a problem hiding this comment.
Bumping only tonic to 0.14 while leaving tonic-build/tonic-reflection on 0.13 introduces an incompatible gRPC stack in this workspace. Tonic’s v0.14 migration requires moving prost-related pieces to the new tonic-prost/tonic-prost-build path, but the repo still uses the 0.13 generator and reflection crates; this is consumed directly by runtime code (e.g. GrpcServer::start builds a reflection service and adds it to tonic::transport::Server in crates/server/service/src/api/grpc_server.rs), so builds can fail due to cross-version tonic types/codegen output.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-0.14
branch
from
dd71a3a to
d27331d
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-0.14
branch
from
d27331d to
6b9dc83
Compare
Updates the requirements on [tonic](https://github.com/hyperium/tonic) to permit the latest version. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.13.0...tonic-v0.14.6) --- updated-dependencies: - dependency-name: tonic dependency-version: 0.14.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/tonic-0.14
branch
from
6b9dc83 to
ad0eaab
Compare
Updates the requirements on tonic to permit the latest version.
Release notes
Sourced from tonic's releases.
Commits
6cb6056chore: release v0.14.6 (#2624)efde924grpc: change helloworld example to pass request as a view (#2632)d47b001transport: add max_frame_size to client Endpoint (#2592)02c01c7Allow setting the HTTP/2 client header table size (#2582)3185354examples: add grpc version of helloworld (#2630)f585303fix(grpc): Fix grpc-google build (#2628)ff7bcbbfeat(grpc): Google call credentials (#2610)f93037bfeat(tonic-xds): make XdsChannelGrpc Sync (#2627)d834bebgrpc: Update Status to be a Result<> and make StatusErr which holds non-OK co...2392224grpc: add route_guide example and make minor tweaks to the generated code API...