Commit 29bbf63
committed
fix: stop assuming HybridBitmap::Large having higher cardinality than Small
Previously, when bitmap_has_all got a Small lhs and a Large rhs, it
simply return false, since a set with fewer cardinality can't has_all
another one with higher cardinality. But due to we don't always demote
Large to Small after cardinality reducing operations, that's not true
anymore.
As a defense, we removed this branch, and the doubting rhs will fall
into branch below, where rhs cardinality is actually checked before
returning false.1 parent 33fabbd commit 29bbf63
1 file changed
Lines changed: 5 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
947 | 947 | | |
948 | 948 | | |
949 | 949 | | |
950 | | - | |
951 | | - | |
952 | | - | |
953 | | - | |
954 | | - | |
955 | | - | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
956 | 953 | | |
957 | 954 | | |
| 955 | + | |
958 | 956 | | |
959 | | - | |
| 957 | + | |
960 | 958 | | |
961 | 959 | | |
962 | 960 | | |
| |||
0 commit comments