Skip to content

Commit a7c4d21

Browse files
authored
fix(ci): drop duplicate --quote-style in tpch/tpcds prepare scripts (#19832)
bendsql_client_connect already passes --quote-style=never, so appending it again in prepare_tpch_data.sh / prepare_tpcds_data.sh makes bendsql fail with 'argument --quote-style cannot be used multiple times'.
1 parent be91a9e commit a7c4d21

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/sqllogictests/scripts/prepare_tpcds_data.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ tables=(
3838

3939
force=${2:-"1"}
4040
if [ "$force" == "0" ]; then
41-
table_exists=$(echo "SELECT COUNT() FROM system.tables WHERE database = '${db}' AND name = 'call_center'" | $BENDSQL_CLIENT_CONNECT --output tsv --quote-style never)
41+
table_exists=$(echo "SELECT COUNT() FROM system.tables WHERE database = '${db}' AND name = 'call_center'" | $BENDSQL_CLIENT_CONNECT --output tsv)
4242
table_exists=$(echo "$table_exists" | tr -d '\r\n[:space:]')
4343
if [ -n "$table_exists" ] && [ "$table_exists" -gt 0 ]; then
44-
res=$(echo "SELECT COUNT() from ${db}.call_center" | $BENDSQL_CLIENT_CONNECT --output tsv --quote-style never)
44+
res=$(echo "SELECT COUNT() from ${db}.call_center" | $BENDSQL_CLIENT_CONNECT --output tsv)
4545
res=$(echo "$res" | tr -d '\r\n[:space:]')
4646
if [ -n "$res" ] && [ "$res" -gt 0 ]; then
4747
echo "Table $db.call_center already exists and is not empty, size: ${res}. Use force=1 to override it."

tests/sqllogictests/scripts/prepare_tpch_data.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ db=${1:-"tpch_test"}
99
force=${2:-"1"}
1010

1111
if [ "$force" == "0" ]; then
12-
table_exists=$(echo "SELECT COUNT() FROM system.tables WHERE database = '${db}' AND name = 'nation'" | $BENDSQL_CLIENT_CONNECT --output tsv --quote-style never)
12+
table_exists=$(echo "SELECT COUNT() FROM system.tables WHERE database = '${db}' AND name = 'nation'" | $BENDSQL_CLIENT_CONNECT --output tsv)
1313
table_exists=$(echo "$table_exists" | tr -d '\r\n[:space:]')
1414
if [ -n "$table_exists" ] && [ "$table_exists" -gt 0 ]; then
15-
res=$(echo "SELECT COUNT() from ${db}.nation" | $BENDSQL_CLIENT_CONNECT --output tsv --quote-style never)
15+
res=$(echo "SELECT COUNT() from ${db}.nation" | $BENDSQL_CLIENT_CONNECT --output tsv)
1616
res=$(echo "$res" | tr -d '\r\n[:space:]')
1717
if [ -n "$res" ] && [ "$res" -gt 0 ]; then
1818
echo "Table $db.nation already exists and is not empty, size: ${res}. Use force=1 to override it."

0 commit comments

Comments
 (0)