fix

Author: zhyass

src/meta/api/src/api_impl/table_api.rs

@@ -389,8 +389,6 @@ where
 
                                 SeqV::new(id.seq, *id.data)
                             } else {
-                                // Reuse the metadata loaded for the engine check when marking the
-                                // existing table as dropped.
                                 let existing = VersionedTable {
                                     id: TableId::new(*id.data),
                                     meta: existing_table_meta,
@@ -1190,7 +1188,7 @@ where
             // get tb_meta of the last table id
             let tbid = TableId { table_id };
             let (tb_meta_seq, tb_meta) = self.get_pb_seq_and_value(&tbid).await?;
-            let mut replacement_meta = tb_meta.ok_or_else(|| {
+            let mut tb_meta = tb_meta.ok_or_else(|| {
                 KVAppError::AppError(AppError::UnknownTableId(UnknownTableId::new(
                     table_id,
                     "commit_table_meta",
@@ -1204,6 +1202,7 @@ where
             );
 
             {
+                // reset drop on time
                 let mut txn_req = TxnRequest::default();
 
                 if let Some(prev_table_id) = req.prev_table_id {
@@ -1218,7 +1217,7 @@ where
                     TableEngineMismatch::ensure(
                         req.name_ident.table_name.as_str(),
                         &previous.engine,
-                        &replacement_meta.engine,
+                        &tb_meta.engine,
                     )
                     .map_err(|e| KVAppError::AppError(e.into()))?;
 
@@ -1228,12 +1227,12 @@ where
                 }
 
                 // undrop a table with no drop_on time
-                if replacement_meta.drop_on.is_none() {
+                if tb_meta.drop_on.is_none() {
                     return Err(KVAppError::AppError(AppError::UndropTableWithNoDropTime(
                         UndropTableWithNoDropTime::new(&tenant_dbname_tbname.table_name),
                     )));
                 }
-                replacement_meta.drop_on = None;
+                tb_meta.drop_on = None;
 
                 txn_req.condition.extend([
                     // db has not to change, i.e., no new table is created.
@@ -1252,7 +1251,7 @@ where
                     txn_put_pb(&DatabaseId { db_id }, &db_meta), // (db_id) -> db_meta
                     txn_put_pb(&dbid_tbname, &TableId::new(table_id)), /* (tenant, db_id, tb_name) -> tb_id */
                     // txn_put_pb(&dbid_tbname_idlist, &tb_id_list), // _fd_table_id_list/db_id/table_name -> tb_id_list
-                    txn_put_pb(&tbid, &replacement_meta), // (tenant, db_id, tb_id) -> tb_meta
+                    txn_put_pb(&tbid, &tb_meta), // (tenant, db_id, tb_id) -> tb_meta
                     txn_del(&orphan_dbid_tbname_idlist), // del orphan table idlist
                     txn_put_pb(&dbid_tbname_idlist, &tb_id_list.data), /* _fd_table_id_list/db_id/table_name -> tb_id_list */
                 ]);