refactor(query): support partitioned hash join#19553
Open
zhang2014 wants to merge 39 commits intodatabendlabs:mainfrom
Open
refactor(query): support partitioned hash join#19553zhang2014 wants to merge 39 commits intodatabendlabs:mainfrom
zhang2014 wants to merge 39 commits intodatabendlabs:mainfrom
Conversation
Under hash shuffle, build and probe data are already partitioned by thread. This replaces the shared hash table (atomic CAS, Mutex, Barrier) with a Doris-style compact hash table (4 bytes/row index-based chain) that each thread builds and probes independently, eliminating all synchronization overhead. - Reorganize memory/ into unpartitioned/ (broadcast) and partitioned/ (shuffle) - Add CompactJoinHashTable<I: RowIndex> with index-based chaining - Add PartitionedBuild with fixed 65536-row chunks and bit-shift addressing - Implement all 7 join types for the partitioned path - Route hash shuffle joins through partitioned pipeline in physical_hash_join Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eam for partitioned hash join Move visited bitmap from CompactJoinHashTable to PartitionedBuild so the hash table is fully immutable after build. Introduce CompactProbeStream implementing the ProbeStream trait for streaming probe with index-based chaining. Replace eager probe()/probe_and_mark_visited() with streaming create_probe_matched/create_probe factory methods. Rewrite all 7 join types (inner, left, left semi, left anti, right, right semi, right anti) with dedicated streaming JoinStream implementations. Right-side joins use field-level split borrowing to avoid borrow conflicts between immutable hash table access and mutable visited marking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
pr-refactor
Contributor
Docker Image for PR
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b9fbcb46a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...service/src/pipelines/processors/transforms/new_hash_join/partitioned/transform_hash_join.rs
Show resolved
Hide resolved
...service/src/pipelines/processors/transforms/new_hash_join/partitioned/transform_hash_join.rs
Outdated
Show resolved
Hide resolved
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
zhang2014
added
ci-cloud
Contributor
Docker Image for PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(query): support partitioned hash join
Tests
Type of change
This change is