fix(query): handle empty LIKE ESCAPE in planner#19595
fix(query): handle empty LIKE ESCAPE in planner#19595KKould merged 7 commits intodatabendlabs:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63f2779b9c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Blocking issue in |
…empty-escape-panic
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
LIKE ... ESCAPE ''panics in planner type checking #19562ESCAPEstring.ESCAPEliterals through the builtinlike/like_anypath instead of planner rewrites.Tests
Validation:
cargo test -p databend-common-sql --test it planner -- --nocapturecargo test -p databend-common-sql --test it test_like_escape_preserves_existing_binding_semantics -- --nocapturecargo clippy -p databend-common-sql --test it -- -D warningscargo fmt --all --checkLogic test added for CI coverage:
tests/sqllogictests/suites/query/issues/issue_19562.testType of change
This change is