fix(ast): avoid round-trip parser panic for nested joins#19605
Open
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Open
fix(ast): avoid round-trip parser panic for nested joins#19605sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Fixes #19571
Summary
Changes
src/query/ast/src/parser/parser.rsso the debug round-trip validation returns an error message instead of panicking/asserting.log::warn!and keepparse_sql()returning the original parsed statement.src/query/ast/tests/it/display.rsfor nested joins that currently lose grouping when displayed.Tests
Validation:
cargo fmt --all --checkcargo test -p databend-common-astcargo clippy -p databend-common-ast --all-targets -- -D warningsType of change
This change is