fix(sql): handle correlated subqueries over union#19607
Merged
KKould merged 3 commits intodatabendlabs:mainfrom Apr 8, 2026
Merged
fix(sql): handle correlated subqueries over union#19607KKould merged 3 commits intodatabendlabs:mainfrom
KKould merged 3 commits intodatabendlabs:mainfrom
Conversation
sundy-li
added
agent-reviewable
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
forsaken628
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
UNION/UNION ALLbranchesEXISTSsubqueries over set operationsChanges
need_cross_joininflatten_sub_union_allwhenever a branch does not cover the full correlated key setunwrap()-based correlated mapping lookups withget_derived()so missing mappings surface as errors instead of panicsUNIONandUNION ALLreprosTests
Unit Test
Logic Test
Benchmark Test
No Test - Pair with the reviewer to explain why
TEST_SUBDIR=regressions cargo test --package databend-common-sql --test it -- planner::test_lite_replay_service_optimizer_cases --exact --nocapturecargo fmt --allType of change
Fixes #19574
This change is