refactor(sql): stabilize binder alias semantics across aggregate, window, and clause rewrites by forsaken628 · Pull Request #19618 · databendlabs/databend

forsaken628 · 2026-03-25T06:34:30Z

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR refactors the SQL binder to preserve a stable semantic view of SELECT aliases across WHERE, HAVING, QUALIFY, and ORDER BY, while separating prepass aggregate discovery from final projection rewriting.

Introduce aggregate prepass alias/catalog analysis to detect aggregate and window dependencies before clause binding.
Keep clause alias resolution based on original SELECT semantics, avoiding accidental dependence on already-rewritten projection state.
Refactor projection handling around SelectInfo, so projection, DISTINCT, and ORDER BY share the same source/projection scalar model.
Tighten QUALIFY, window, grouping, and aggregate interactions, including UDAF and SRF edge cases.
Expand binder semantic coverage with focused golden tests for clauses, grouping, window paths, named windows, and subquery metadata side effects.

Tests

Unit Test
Logic Test
Benchmark Test
No Test - Explain why

Type of change

Bug Fix (non-breaking change which fixes an issue)
New Feature (non-breaking change which adds functionality)
Breaking Change (fix or feature that could cause existing functionality not to work as expected)
Documentation Update
Refactoring
Performance Improvement
Other (please describe):

This change is

… tests

…nt matching

…n bind_select

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3e27b5af4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/query/sql/src/planner/binder/window.rs

# Conflicts: # src/query/sql/src/planner/binder/distinct.rs # src/query/sql/src/planner/binder/having.rs # src/query/sql/src/planner/binder/project.rs # src/query/sql/src/planner/binder/qualify.rs # src/query/sql/src/planner/binder/sort.rs # src/query/sql/src/planner/binder/window.rs # src/query/sql/src/planner/semantic/grouping_check.rs # src/query/sql/tests/it/semantic/binder.rs # src/query/sql/tests/it/semantic/binder.txt

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6ceca131c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/query/sql/src/planner/binder/bind_query/bind_select.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d119cbbbdf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/query/sql/src/planner/binder/aggregate.rs

forsaken628 · 2026-04-03T03:12:47Z

@codex review

chatgpt-codex-connector · 2026-04-03T03:23:18Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49600e97fa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/query/sql/src/planner/binder/aggregate.rs

forsaken628 added 19 commits March 24, 2026 09:41

refactor(sql): use structural matching for aggregate/UDAF deduplication

04c80f8

feat(sql): add query-local UDF definition cache in BindContext

fa8f708

refactor(sql): rewrite aggregate binder with intern/lookup pattern

505a45f

fix(sql): make grouping() rewrite idempotent and add window aggregate…

d3727a5

… tests

test: migrate tests to integration framework with golden files

b9050a5

fix(sql): reject aggregate functions in window partition/order spec

5b33901

refactor(sql): add lookup_existing methods for pre-argument-replaceme…

a5c455b

…nt matching

refactor(sql): simplify project_set and qualify binder

802885d

test(sql): add comprehensive binder semantic tests

b879728

refactor(sql): simplify aggregate argument replacement logic

3b7056b

fix(sql): fix window function type checking for nested aggregates

8edc264

test: add UserApiProvider support to test framework

4c3b935

refactor(sql): update aggregate binding, qualify, and sort handling

082b2cc

refactor(sql): simplify qualify clause and improve grouping check

507b9c8

feat(sql): add push_down_filter for ProjectSet and fix SRF ordering i…

288e75a

…n bind_select

fix

1259f6f

fix

f4e00ba

init

ecf76d3

x

a3e27b5

github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 25, 2026

forsaken628 marked this pull request as draft March 25, 2026 06:34

chatgpt-codex-connector bot reviewed Mar 25, 2026

View reviewed changes

src/query/sql/src/planner/binder/window.rs Show resolved Hide resolved

forsaken628 changed the title ~~refactor(sql): projection-bind~~ refactor(sql): unify select output planning and preserve aggregate reuse in window analysis Apr 1, 2026

forsaken628 force-pushed the projection-bind branch 2 times, most recently from 256446d to a6ceca1 Compare April 1, 2026 12:52

forsaken628 marked this pull request as ready for review April 1, 2026 13:01

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

src/query/sql/src/planner/binder/bind_query/bind_select.rs Outdated Show resolved Hide resolved

forsaken628 marked this pull request as draft April 2, 2026 02:53

fix

aabc196

forsaken628 force-pushed the projection-bind branch from a6ceca1 to aabc196 Compare April 2, 2026 03:20

forsaken628 added 2 commits April 2, 2026 13:39

fix

1809872

Merge remote-tracking branch 'up/main' into projection-bind

d119cbb

forsaken628 marked this pull request as ready for review April 2, 2026 07:09

chatgpt-codex-connector bot reviewed Apr 2, 2026

View reviewed changes

src/query/sql/src/planner/binder/aggregate.rs Show resolved Hide resolved

fix

2983534

forsaken628 requested review from TCeason and b41sh April 3, 2026 04:08

forsaken628 marked this pull request as draft April 3, 2026 06:36

refine

49600e9

forsaken628 changed the title ~~refactor(sql): unify select output planning and preserve aggregate reuse in window analysis~~ refactor(sql): stabilize binder alias semantics across aggregate, window, and clause rewrites Apr 3, 2026

forsaken628 marked this pull request as ready for review April 3, 2026 09:23

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

src/query/sql/src/planner/binder/aggregate.rs Outdated Show resolved Hide resolved

fix

ec77883

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(sql): stabilize binder alias semantics across aggregate, window, and clause rewrites#19618

refactor(sql): stabilize binder alias semantics across aggregate, window, and clause rewrites#19618
forsaken628 wants to merge 26 commits intodatabendlabs:mainfrom
forsaken628:projection-bind

forsaken628 commented Mar 25, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

forsaken628 commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

forsaken628 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Type of change

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

forsaken628 commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

forsaken628 commented Mar 25, 2026 •

edited

Loading