fix: use spill depth partition bit in new final agg#19626
Open
dqhl76 wants to merge 6 commits intodatabendlabs:mainfrom
Open
fix: use spill depth partition bit in new final agg#19626dqhl76 wants to merge 6 commits intodatabendlabs:mainfrom
dqhl76 wants to merge 6 commits intodatabendlabs:mainfrom
Conversation
dqhl76
commented
Mar 27, 2026
Comment on lines
-177
to
-183
| for payload in payloads { | ||
| let restored = self.spiller.restore(payload)?; | ||
| let AggregateMeta::Serialized(restored) = restored else { | ||
| unreachable!("unexpected aggregate meta, found type: {:?}", restored) | ||
| }; | ||
| self.handle_serialized(restored)?; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Need check spill for every payload
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9cccc35fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...rc/pipelines/processors/transforms/aggregator/new_aggregate/new_transform_final_aggregate.rs
Outdated
Show resolved
Hide resolved
dqhl76
force-pushed
the
fix-final-aggregate-bug
branch
from
c9cccc3 to
9ce4bc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
part of #19622
Context: In the final aggregation stage, incoming data is already partitioned by the partial aggregation stage. As a result, when spilling occurs, all data falls into a single bucket.
Issue: Our design intended to halve memory usage during a spill, but a bug prevented this from happening.
Fix: This commit resolves the issue by adjusting the start bit, which correctly splits the data into two parts.
Testing: Verified by regression test test_partition_mask_with_start_bit.
Tests
Type of change
This change is