refactor: split oversized blocks in BlockPartitionStream and add unit tests #19627
Open
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
Open
refactor: split oversized blocks in BlockPartitionStream and add unit tests #19627dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
Conversation
github-actions
bot
added
the
pr-refactor
Prevent BlockPartitionStream from emitting blocks larger than rows_threshold by splitting them after build. Also adds comprehensive unit tests covering partition, finalize_partition, and take_partitions split behavior.
dqhl76
force-pushed
the
fix-final-aggregate-2
branch
from
4ffe891 to
62c91dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
part of #19622
Prevent BlockPartitionStream from emitting blocks larger than rows_threshold
by splitting them after build. Also adds comprehensive unit tests covering
partition, finalize_partition, and take_partitions split behavior.
Tests
Type of change
This change is