Skip to content

ci: improve the benchmarking report to include more details#19994

Merged
forsaken628 merged 5 commits into
databendlabs:mainfrom
forsaken628:benchmark-report
Jun 15, 2026
Merged

ci: improve the benchmarking report to include more details#19994
forsaken628 merged 5 commits into
databendlabs:mainfrom
forsaken628:benchmark-report

Conversation

@forsaken628

@forsaken628 forsaken628 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR rewrites the cloud benchmark runner in Rust with databend-driver, keeping the existing result schema compatible while adding richer per-query detail collection.

  • Collect per-attempt query details, including query id, server stats, system.query_execution, system_history.query_history, and system_history.profile_history.
  • Add a Download Plaintext Data link after Changeset Detail so the decompressed benchmark data can still be inspected directly.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): ci

This change is Reviewable

@forsaken628 forsaken628 changed the title test: improve the benchmarking report to include more details ci: improve the benchmarking report to include more details Jun 11, 2026
@github-actions github-actions Bot added the pr-build this PR changes build/testing/ci steps label Jun 11, 2026
@forsaken628 forsaken628 added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Docker Image for PR

  • tag: pr-19994-369fc20-1781165106

note: this image tag is only available for internal use.

@forsaken628 forsaken628 added ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits and removed ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits labels Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Docker Image for PR

  • tag: pr-19994-209be0f-1781173180

note: this image tag is only available for internal use.

@github-actions

Copy link
Copy Markdown
Contributor

@forsaken628 forsaken628 added ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits and removed ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits labels Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Docker Image for PR

  • tag: pr-19994-5547c81-1781236162

note: this image tag is only available for internal use.

@github-actions

Copy link
Copy Markdown
Contributor

@forsaken628 forsaken628 marked this pull request as ready for review June 13, 2026 06:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8219fbd033

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread benchmark/src/bin/benchmark_cloud.rs
Comment thread benchmark/src/bin/benchmark_cloud.rs
@zhang2014 zhang2014 requested a review from everpcpc June 14, 2026 04:52
@forsaken628 forsaken628 added this pull request to the merge queue Jun 15, 2026
Merged via the queue into databendlabs:main with commit e8b178e Jun 15, 2026
9 checks passed
@forsaken628 forsaken628 deleted the benchmark-report branch June 15, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-build this PR changes build/testing/ci steps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants