refactor(query): unify window/cte spill to async_buffer path #20001
Merged
Conversation
github-actions
Bot
added
the
pr-refactor
dqhl76
force-pushed
the
clean-aggregate
branch
2 times, most recently
from
74d562f to
d07c366
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d07c3663f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dqhl76
force-pushed
the
clean-aggregate
branch
2 times, most recently
from
6ed3478 to
114f643
Compare
Migrate WindowPartitionBufferV2 and MaterializedCTE from the BackpressureSpiller -> WriterCreator -> SpillWriter -> AnyFileWriter chain to the SpillsBufferPool -> SpillsDataWriter/SpillsDataReader path used by aggregate and join operators. Key changes: - Rewrite window_partition_buffer_v2 to use SpillsDataWriter directly - Rewrite materialized_cte to use SpillsBufferPool.writer() - Remove BackpressureSpiller, WriterCreator, SpillWriter, SpillReader - Remove row_group_encoder.rs (FileWriter, LocalWriter, AnyFileWriter, RowGroupEncoder, Properties, RangeFetchPlan, FileReader) - Remove V1 WindowPartitionBuffer (async Spiller path) - Drop local DMA support for window/cte spill - Add SpillsDataWriter::flush_row_group() for explicit row group control Reduce from 5-state machine (Collect/Spill/Process/Restore/Finish) to 3-state (Collect/Output/Finish). Since spill and restore are now both synchronous, the indirection through separate Spill/Restore steps with async fallback is unnecessary. - Collect: pull data, buffer, spill inline when memory pressure is high - Output: restore next partition, process (sort), push downstream - Remove next_step(), collect(), output() helper methods - Remove is_collect_finished, restored_data_blocks fields
zhang2014
approved these changes
Jun 12, 2026
forsaken628
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(query): unify window/cte spill to async_buffer path
Tests
Type of change
This change is