feat(query): reject alter view definition changes - #20202
Merged
youngsofun merged 1 commit intoJul 24, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
|
LGTM. Please modify the doc. |
TCeason
approved these changes
Jul 24, 2026
b41sh
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Reject
ALTER VIEWoperations that replace a view's query or output-column definition.This change was split out of the data-lineage PR #20198 so its behavioral impact can be reviewed independently. #20198 no longer contains or depends on this commit. Merging this PR first would nevertheless give lineage a simpler invariant: a view's stored definition cannot change without replacing the view and its dependency metadata together.
Motivation
The current
ALTER VIEW <name> [(columns)] AS <query>path replaces the stored SQL definition in place. Once view dependencies are persisted, allowing this operation without atomically replacing all object and column lineage can leave metadata describing the previous query.For now, the binder returns
Unimplementedfor query-definition changes. The existing view remains unchanged after a rejected statement.This does not affect independent operations such as setting tags.
CREATE OR REPLACE VIEWremains the explicit replacement path. A future change can add:when rename semantics are implemented.
The obsolete ALTER VIEW definition-replacement sqllogic suite is removed, and the existing CREATE VIEW suite verifies that a rejected ALTER does not damage the view.
Tests
Type of change
This change is