fix(meta): disallow replacing tables with different engines - #20234
Open
zhyass wants to merge 2 commits into
Open
fix(meta): disallow replacing tables with different engines#20234zhyass wants to merge 2 commits into
zhyass wants to merge 2 commits into
Conversation
drmingdrmer
requested changes
Jul 31, 2026
drmingdrmer
left a comment
Member
There was a problem hiding this comment.
@drmingdrmer reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on dantengsky, SkyFan2002, TCeason, and zhyass).
src/meta/api/src/api_impl/table_api.rs line 379 at r1 (raw file):
if !existing_meta .engine .eq_ignore_ascii_case(&req.table_meta.engine)
why is this check done only when as_dropped is set? the codes does not tell the reason behind it.
Code quote:
if req.as_dropped {
// CTAS does not call construct_drop_table_txn_operations(),
// so validate its existing table here.
let existing_meta =
self.get_pb(&TableId::new(*id.data)).await?.ok_or_else(|| {
KVAppError::AppError(AppError::UnknownTableId(
UnknownTableId::new(
*id.data,
"create or replace failed to find existing table meta",
),
))
})?;
if !existing_meta
.engine
.eq_ignore_ascii_case(&req.table_meta.engine)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
CREATE OR REPLACEwhen an existing table uses a different engine.Tests
Type of change
AI assistance
This change is