ADD: Add batch download logging

Author: threecgreen

CHANGELOG.md

@@ -5,10 +5,14 @@
 
 ### Enhancements
 - Added `range_by_schema` field to `DatasetRange` struct
+- Added logging around `Historical::BatchDownload`
 - Changed the following Venue, Publisher, and Dataset descriptions:
   - "ICE Futures Europe (Financials)" renamed to "ICE Europe Financials"
   - "ICE Futures Europe (Commodities)" renamed to "ICE Europe Commodities"
 
+### Bug fixes
+- Fixed default `ShouldLog` implementation
+
 ## 0.38.0 - 2025-06-10
 
 ### Enhancements

include/databento/log.hpp

@@ -37,7 +37,7 @@ class ConsoleLogReceiver : public ILogReceiver {
 
   void Receive(LogLevel level, const std::string& msg) override;
   bool ShouldLog(databento::LogLevel level) const override {
-    return level > min_level_;
+    return level >= min_level_;
   }
 
  private:

src/historical.cpp

@@ -1,9 +1,5 @@
 #include "databento/historical.hpp"
 
-#include <unordered_map>
-
-#include "databento/publishers.hpp"
-
 #ifndef CPPHTTPLIB_OPENSSL_SUPPORT
 #define CPPHTTPLIB_OPENSSL_SUPPORT
 #endif
@@ -18,6 +14,7 @@
 #include <sstream>
 #include <string>
 #include <system_error>
+#include <unordered_map>
 #include <utility>  // move
 
 #include "databento/constants.hpp"
@@ -332,25 +329,36 @@ void Historical::StreamToFile(const std::string& url_path,
 
 void Historical::DownloadFile(const std::string& url,
                               const std::filesystem::path& output_path) {
-  static const std::string kEndpoint = "Historical::DownloadFile";
+  static const std::string kMethod = "Historical::DownloadFile";
   // extract path from URL
   const auto protocol_divider = url.find("://");
   std::string path;
+
   if (protocol_divider == std::string::npos) {
     const auto slash = url.find_first_of('/');
     if (slash == std::string::npos) {
-      throw InvalidArgumentError{kEndpoint, "url", "No slashes"};
+      throw InvalidArgumentError{kMethod, "url", "No slashes"};
     }
     path = url.substr(slash);
   } else {
     const auto slash = url.find('/', protocol_divider + 3);
     if (slash == std::string::npos) {
-      throw InvalidArgumentError{kEndpoint, "url", "No slashes"};
+      throw InvalidArgumentError{kMethod, "url", "No slashes"};
     }
     path = url.substr(slash);
   }
+  std::ostringstream ss;
+  ss << '[' << kMethod << "] Downloading batch file " << path << " to "
+     << output_path;
+  log_receiver_->Receive(LogLevel::Info, ss.str());
 
   StreamToFile(path, {}, output_path);
+
+  if (log_receiver_->ShouldLog(LogLevel::Debug)) {
+    ss.str("");
+    ss << '[' << kMethod << ']' << " Completed download of " << path;
+    log_receiver_->Receive(LogLevel::Debug, ss.str());
+  }
 }
 
 std::vector<databento::PublisherDetail> Historical::MetadataListPublishers() {

tests/src/log_tests.cpp

@@ -1,9 +1,10 @@
-#include <gtest/gtest.h>
+#include <gmock/gmock.h>
 
 #include <sstream>
 #include <string>
 
 #include "databento/log.hpp"
+#include "gmock/gmock.h"
 
 namespace databento::tests {
 class ConsoleLogReceiverTests : public testing::Test {
@@ -24,7 +25,9 @@ TEST_F(ConsoleLogReceiverTests, TestFilter) {
   const std::string msg = "Something happened";
   target_.Receive(LogLevel::Debug, msg);
   const std::string output = stream_.str();
-  ASSERT_TRUE(output.empty());
+  EXPECT_TRUE(output.empty());
+  target_.Receive(LogLevel::Info, msg);
+  EXPECT_THAT(stream_.str(), testing::HasSubstr(msg));
 }
 
 TEST(ILogReceiverTests, TestDefault) {